-
Notifications
You must be signed in to change notification settings - Fork 16
update known_good to latest mains #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update known_good to latest mains #78
Conversation
|
mhh some tests fail |
|
The created documentation from the pull request is available at: docu-html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the known_good.json file to reference the latest main branch commits of various Score modules, switching from versioned single_version_override to direct git commit references using git_override. The changes also include improved error handling for known_good file operations and workarounds for Rust KVS API limitations.
Changes:
- Updated all module references in
known_good.jsonandscore_modules.MODULE.bazelto use latest main branch commits instead of release versions - Improved error handling in known_good loading scripts to use specific exception types instead of broad catches
- Added workarounds in Rust code for missing
dir()andsnapshot_max_count()methods by usingJsonBackendBuilderdirectly - Disabled failing communication and persistency unit tests with documented linker issues
- Updated Python and Rust Bazel dependencies to newer versions
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| known_good.json | Removed version fields and updated all module commit hashes to latest main branch commits |
| score_modules.MODULE.bazel | Changed from single_version_override to git_override with commit references for all modules |
| scripts/known_good/models/known_good.py | Changed SystemExit to ValueError for invalid known_good format errors |
| scripts/known_good/update_module_latest.py | Split exception handling to catch FileNotFoundError and ValueError separately |
| scripts/known_good/update_module_from_known_good.py | Added specific exception handling for known_good loading |
| scripts/known_good/override_known_good_repo.py | Added try-except blocks for known_good loading errors |
| scripts/known_good/known_good_to_workspace_metadata.py | Added specific exception handling for known_good loading |
| scripts/integration_test.py | Added exception handling for known_good loading with empty dict fallback |
| scripts/run_unit_tests.sh | Disabled communication tests and excluded failing persistency/logging tests with documented reasons |
| feature_showcase/rust/orchestration_persistency/main.rs | Added workaround using JsonBackendBuilder instead of unavailable dir() method |
| feature_integration_tests/test_scenarios/rust/src/scenarios/basic/orchestration_with_persistency.rs | Replaced dir() and snapshot_max_count() calls with JsonBackendBuilder workaround |
| feature_integration_tests/test_scenarios/rust/src/internals/persistency/kvs_instance.rs | Updated to use JsonBackendBuilder for directory and snapshot configuration |
| feature_integration_tests/test_cases/BUILD | Renamed pytest_ini parameter to pytest_config |
| MODULE.bazel | Updated rules_python to 1.5.1, rules_rust to 0.67.0, and score_crates to 0.0.6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.