Skip to content

KVS new Design #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Ahmed-Elsaka-JC wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

KVS new Design #172

Ahmed-Elsaka-JC wants to merge 5 commits into from
+145 −0

Conversation

@Ahmed-Elsaka-JC
Copy link
Contributor

@Ahmed-Elsaka-JC Ahmed-Elsaka-JC commented Nov 21, 2025 •
edited
Loading

New Design for KVS

@github-actions
Copy link

github-actions bot commented Nov 21, 2025 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: a9de1036-2ebb-4370-a961-49975dc98694
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rules_boost+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-LTilyiMMjpYyAi1PW+8RycyAEHy9clo7915R0Bchb2E="
DEBUG: Repository rules_boost+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 2 packages loaded
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)

Analyzing: target //:license-check (70 packages loaded, 9 targets configured)

Analyzing: target //:license-check (75 packages loaded, 9 targets configured)

Analyzing: target //:license-check (131 packages loaded, 1441 targets configured)

Analyzing: target //:license-check (138 packages loaded, 2849 targets configured)

Analyzing: target //:license-check (139 packages loaded, 2857 targets configured)

Analyzing: target //:license-check (139 packages loaded, 2857 targets configured)

Analyzing: target //:license-check (140 packages loaded, 2857 targets configured)

Analyzing: target //:license-check (142 packages loaded, 4864 targets configured)

Analyzing: target //:license-check (142 packages loaded, 4864 targets configured)

Analyzing: target //:license-check (142 packages loaded, 4864 targets configured)

Analyzing: target //:license-check (142 packages loaded, 4864 targets configured)

Analyzing: target //:license-check (142 packages loaded, 4864 targets configured)

Analyzing: target //:license-check (142 packages loaded, 4864 targets configured)

Analyzing: target //:license-check (142 packages loaded, 4864 targets configured)

DEBUG: Rule 'toolchains_llvm++llvm+llvm_toolchain_llvm' indicated that a canonical reproducible form can be obtained by modifying arguments _action_listener = <unknown object com.google.devtools.build.lib.packages.Attribute$LabelListLateBoundDefault>, _config_dependencies = [], _configure = False, _environ = [], _original_name = "llvm_toolchain_llvm"
DEBUG: Repository toolchains_llvm++llvm+llvm_toolchain_llvm instantiated at:
  <builtin>: in <toplevel>
Repository rule llvm defined at:
  /home/runner/.bazel/external/toolchains_llvm+/toolchain/rules.bzl:27:23: in <toplevel>
Analyzing: target //:license-check (142 packages loaded, 4864 targets configured)

INFO: Analyzed target //:license-check (143 packages loaded, 6799 targets configured).
[8 / 14] checking cached actions
[13 / 14] [Prepa] Generating Dash formatted dependency file ...
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 65 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 208.995s, Critical Path: 0.26s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

The created documentation from the pull request is available at: docu-html

@arkjedrz arkjedrz self-requested a review December 18, 2025 07:47
arkjedrz
arkjedrz suggested changes Dec 18, 2025
View reviewed changes
Design/Design_puml.puml Outdated

class IKvsBuilder <<implementation>> {
- instance_id: InstanceId
- need_defaults : bool
Copy link
Contributor

@arkjedrz arkjedrz Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> -defaults : KvsDefaults

Copy link
Contributor Author

@Ahmed-Elsaka-JC Ahmed-Elsaka-JC Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

@Ahmed-Elsaka-JC Ahmed-Elsaka-JC Jan 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected values :

  • true : default storage must be exist
  • false : default storage may not be exist
  • Ignores : ignore default values even if we have default values storage.

- new ticket should be created to make c++ support this as rust.

Design/Design_puml.puml Outdated
class IKvsBuilder <<implementation>> {
- instance_id: InstanceId
- need_defaults : bool
- need_kvs : bool
Copy link
Contributor

@arkjedrz arkjedrz Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> -kvs_load : KvsLoad

Copy link
Contributor Author

@Ahmed-Elsaka-JC Ahmed-Elsaka-JC Jan 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kvs_load = OpenNeedKvs :
OpenNeedKvs has two values now :
new value will be added "IGNORE"

new ticket should be created to make c++ support this as rust.

Design/Design_puml.puml Outdated
+ set_value(Key:string, value:KvsValue): ResultBlank
+ remove_key(Key:string) : ResultBlank
+ flush() : ResultBlank
+ snapshot_count: Result<size_t>
Copy link
Contributor

@arkjedrz arkjedrz Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a function.

Copy link
Contributor Author

@Ahmed-Elsaka-JC Ahmed-Elsaka-JC Jan 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arkjedrz what is meant by this if a function ?

Design/Design_puml.puml Outdated
Copy link
Contributor

@arkjedrz arkjedrz Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding names - please align with https://github.com/qorix-group/persistency/blob/e3945d4bea1bb3627dd46835db403b0c460306d1/docs/class_diagram.puml

tizava
tizava suggested changes Dec 18, 2025
View reviewed changes
Design/Design_puml.puml Outdated
Copy link

@tizava tizava Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this file is not included in any index file

Copy link
Contributor Author

@Ahmed-Elsaka-JC Ahmed-Elsaka-JC Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@Ahmed-Elsaka-JC
update class diagram for kvs
d3ac541 
- class diagram represent new design of score kvs.
@Ahmed-Elsaka-JC Ahmed-Elsaka-JC changed the title Draft KVS new Design Jan 14, 2026
arkjedrz
arkjedrz suggested changes Jan 20, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@arkjedrz arkjedrz arkjedrz requested changes

@tizava tizava tizava requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ahmed-Elsaka-JC @arkjedrz @tizava