Skip to content

Conversation

@RSingh1511
Copy link
Contributor

@RSingh1511 RSingh1511 commented Jan 16, 2026

  • Add qnx_x86_64 and qnx_arm64 build configurations in .bazelrc
  • Register QNX QCC toolchains for x86_64 and aarch64 in MODULE.bazel
  • Make qnx_creds.py executable for credential helper functionality

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

- Add qnx_x86_64 and qnx_arm64 build configurations in .bazelrc
- Register QNX QCC toolchains for x86_64 and aarch64 in MODULE.bazel
- Make qnx_creds.py executable for credential helper functionality

Issue: SWP-235282
@github-actions
Copy link

github-actions bot commented Jan 16, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 8ed3bda0-9292-448b-bb3b-177f2a86d9c6
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-eQOopREOYCL5vtTb6c1cwZrql4GVrJ1FqgxarQRe1xs="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 13.062s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

Copy link
Contributor

@rmaddikery rmaddikery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is scripts/internal/qnx_creds.py an empty file?

common:qnx_x86_64 --sandbox_writable_path=/var/tmp

common:qnx_arm64 --host_platform=@score_bazel_platforms//:x86_64-linux
common:qnx_arm64 --platforms=@score_bazel_platforms//:arm64-qnx8_0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consolidate this section with line 39-43!

Otherwise this is just repetitive

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@pawelrutkaq pawelrutkaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add qnx builds jobs from reusable workflows in score.

MODULE.bazel Outdated
use_repo(toolchains_qnx, "toolchains_qnx_qcc")
use_repo(toolchains_qnx, "toolchains_qnx_ifs")

register_toolchains("@toolchains_qnx_qcc//:qcc_x86_64")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall never be registered

@RSingh1511
Copy link
Contributor Author

Why is scripts/internal/qnx_creds.py an empty file?

just change the permission of qnx_cred file. Yes, it’s needed: qnx_creds.py must be executable so Bazel can run it as --credential_helper during the QNX SDP fetch from qnx.com otherwise downloads fail

- Add common:qnx base config to eliminate duplication.
- Set qnx_creds.py as executable for credential helper

Issue: SWP-235282
@RSingh1511 RSingh1511 temporarily deployed to workflow-approval January 16, 2026 10:00 — with GitHub Actions Inactive
@rmaddikery
Copy link
Contributor

please add qnx builds jobs from reusable workflows in score.

@Rahul-Sutariya
Here's an example: https://github.com/eclipse-score/communication/blob/main/.github/workflows/build_and_test_qnx.yml
Another example PR that setup a workflow using gcc toolchain:
#7

@pawelrutkaq
Copy link
Contributor

pawelrutkaq commented Jan 16, 2026

please add qnx builds jobs from reusable workflows in score.

@Rahul-Sutariya Here's an example: https://github.com/eclipse-score/communication/blob/main/.github/workflows/build_and_test_qnx.yml Another example PR that setup a workflow using gcc toolchain: #7

We shall sue reusable workflows. https://github.com/eclipse-score/cicd-workflows
You can look into usage at https://github.com/eclipse-score/baselibs_rust

@pawelrutkaq
Copy link
Contributor

Btw this has to go along with new rust toolchain for toolchain_rust .0.3.0 if you want to add x86_64 QNX

- Add QNX build configs and CI workflow using reusable workflows
@RSingh1511
Copy link
Contributor Author

please add qnx builds jobs from reusable workflows in score.

@Rahul-Sutariya Here's an example: https://github.com/eclipse-score/communication/blob/main/.github/workflows/build_and_test_qnx.yml Another example PR that setup a workflow using gcc toolchain: #7

We shall sue reusable workflows. https://github.com/eclipse-score/cicd-workflows You can look into usage at https://github.com/eclipse-score/baselibs_rust

Done: Added QNX builds using reusable workflows from eclipse-score/cicd-workflows. Both x86_64 and arm64 jobs are included

- Add copyright header to QNX CI workflow file
@RSingh1511 RSingh1511 temporarily deployed to workflow-approval January 19, 2026 14:00 — with GitHub Actions Inactive
@RSingh1511 RSingh1511 temporarily deployed to workflow-approval January 20, 2026 08:46 — with GitHub Actions Inactive
FScholPer
FScholPer previously approved these changes Jan 20, 2026
Configure QNX toolchains for x86_64 and arm64 platforms with
S-CORE reusable workflows. Enable Rust support for arm64-qnx.
@RSingh1511 RSingh1511 temporarily deployed to workflow-approval January 21, 2026 10:08 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants