Skip to content

Conversation

@MaximilianSoerenPollak
Copy link
Contributor

📌 Description

Removes quotes around the name of the document source (e.g 'docs' => docs) to fix the edit on github link

Fixes: #348

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

Removing quotations around the source dir fixes the links
@github-actions
Copy link

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: a09118b6-8c32-4db4-835e-c9bd9a5294a7
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (70 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (88 packages loaded, 240 targets configured)

Analyzing: target //src:license-check (129 packages loaded, 2435 targets configured)

Analyzing: target //src:license-check (134 packages loaded, 2484 targets configured)

INFO: Analyzed target //src:license-check (137 packages loaded, 4500 targets configured).
[10 / 13] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 12.923s, Critical Path: 0.45s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@AlexanderLanin
Copy link
Member

wont this fail with spaces etc?

@MaximilianSoerenPollak
Copy link
Contributor Author

MaximilianSoerenPollak commented Jan 20, 2026

wont this fail with spaces etc?

Which demon has spaces in folder names?

But yes, this could be an issue.
Let me test this locally quickly.

I move it to draft meanwhile

@MaximilianSoerenPollak MaximilianSoerenPollak marked this pull request as draft January 20, 2026 13:00
@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@MaximilianSoerenPollak
Copy link
Contributor Author

wont this fail with spaces etc?

I tested it on WSL with new folder test as the source directory for the documentation.
And that seems to work just fine. As the source_dir is passed inside the BUILD file, not via command line.

image

Resulting link:
image

Directory:
image

So seems okay for me?

@MaximilianSoerenPollak MaximilianSoerenPollak marked this pull request as ready for review January 20, 2026 13:09
Copy link
Member

@AlexanderLanin AlexanderLanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black space magic 😆

@AlexanderLanin AlexanderLanin merged commit 5486317 into eclipse-score:main Jan 20, 2026
10 checks passed
@github-project-automation github-project-automation bot moved this from Draft to Done in Infrastructure Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

"Edit on github" link is wrong

3 participants