fix issues which prevent latest main update #349

RolandJentschETAS · 2026-01-20T10:56:18Z

📌 Description

fix issues which prevent latest main update.
Otherwise integration fails (bazel run //:docs_combo_experimental does not run)

🚨 Impact Analysis

This change does not violate any tool requirements and is covered by existing tool requirements
This change does not violate any design decisions
Otherwise I have created a ticket for new tool qualification

✅ Checklist

Added/updated documentation for new or changed features
Added/updated tests to cover the changes
Followed project coding standards and guidelines

github-actions · 2026-01-20T10:57:12Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 6b1b4520-e0c3-436e-866d-92bcb0a91638
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (73 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (126 packages loaded, 1686 targets configured)

Analyzing: target //src:license-check (134 packages loaded, 2484 targets configured)

INFO: Analyzed target //src:license-check (137 packages loaded, 4500 targets configured).
[4 / 12] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 14.918s, Critical Path: 0.44s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-01-20T11:03:16Z

The created documentation from the pull request is available at: docu-html

MaximilianSoerenPollak · 2026-01-20T12:26:23Z

docs/internals/requirements/requirements.rst

-    gd_req__impl_design_code_link,

-  Docs-as-Code shall allow source code to link to needs.
+  Docs-as-Code shall allow source code to link to requirement needs.


It can be any need though, right? Tests, requirements, documents etc.
So I guess maybe better to say Sphinx-Needs ?

No, at this place (from the upper layer linked requirement gd_req__req_attr_impl) only requirements need to be linked.

Add sphinx needs to text before requirement mentioned

I would keep it as is to be honest. We intentionally said "needs" here, as our tool supports more than the process requires.

src/extensions/score_metamodel/metamodel.yaml

MaximilianSoerenPollak

Just two quick comments.

Though they can also be fixed in future PR.

Update documentation to specify 'sphinx-needs' for linked requirements. Signed-off-by: RolandJentschETAS <[email protected]>

Removed commented-out req-Id section from metamodel.yaml. Signed-off-by: RolandJentschETAS <[email protected]>

Signed-off-by: RolandJentschETAS <[email protected]>

a-zw · 2026-01-20T13:02:18Z

docs/internals/requirements/requirements.rst

+..    :satisfies: gd_req__impl_dynamic_diagram

-   Provide needs type ``dd_dyn`` for dynamic diagrams showing unit interactions as UML.
+..    Provide needs type ``dd_dyn`` for dynamic diagrams showing unit interactions as UML.


Commenting is not a good idea. Delete it.

a-zw · 2026-01-20T13:03:10Z

src/extensions/score_metamodel/metamodel.yaml

    parts: 3

-  # req-Id: tool_req__docs_dd_dyn
  dd_dyn:


If there is no requirement for the dd_dyn element, shouldn't we delete it from the metamodel?

The problem is, that the process description of the implementation process still contains a dynamic diagram, but the process requirement is gone. So it is currently unclear if deletion of the requirement was a mistake or not. The PR is only to make overall update is running. But it don't solve the issue, that the implementation process contains undefined parts. But this is in another repo and must be fixed after discussion.

AlexanderLanin

Open points remain relevant; and please do address them!
However they can equally well be addressed post merge, so I'm merging this now.

AlexanderLanin · 2026-01-20T17:35:13Z

docs/internals/requirements/requirements.rst

-    gd_req__impl_design_code_link,

-  Docs-as-Code shall allow source code to link to needs.
+  Docs-as-Code shall allow source code to link to requirement sphinx-needs objects.


I would keep this as it was, since our tool requirement intentionally did not differentiate whether its a requirement or not. The tool was more generic, then the minimum process requirement.

fix issues which prevent latest main update

c59113c

RolandJentschETAS requested review from AlexanderLanin, MaximilianSoerenPollak, dcalavrezo-qorix and nradakovic as code owners January 20, 2026 10:56

github-project-automation bot added this to Infrastructure Jan 20, 2026

github-project-automation bot moved this to Draft in Infrastructure Jan 20, 2026

MaximilianSoerenPollak reviewed Jan 20, 2026

View reviewed changes

src/extensions/score_metamodel/metamodel.yaml Outdated Show resolved Hide resolved

MaximilianSoerenPollak previously approved these changes Jan 20, 2026

View reviewed changes

Clarify linked requirement documentation

31fb7a0

Update documentation to specify 'sphinx-needs' for linked requirements. Signed-off-by: RolandJentschETAS <[email protected]>

RolandJentschETAS dismissed MaximilianSoerenPollak’s stale review via 31fb7a0 January 20, 2026 12:49

RolandJentschETAS added 2 commits January 20, 2026 13:50

Remove commented-out req-Id from metamodel.yaml

3454b84

Removed commented-out req-Id section from metamodel.yaml. Signed-off-by: RolandJentschETAS <[email protected]>

Update documentation for linking requirements in Docs-as-Code

fcedae9

Signed-off-by: RolandJentschETAS <[email protected]>

a-zw suggested changes Jan 20, 2026

View reviewed changes

a-zw mentioned this pull request Jan 20, 2026

Update score_process to 1.4.2 #351

Draft

6 tasks

AlexanderLanin approved these changes Jan 20, 2026

View reviewed changes

AlexanderLanin merged commit d9f95fd into eclipse-score:main Jan 20, 2026
10 checks passed

AlexanderLanin deleted the fix_latest_main_update branch January 20, 2026 17:35

github-project-automation bot moved this from Draft to Done in Infrastructure Jan 20, 2026

fix issues which prevent latest main update #349

fix issues which prevent latest main update #349

Conversation

RolandJentschETAS commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Description

🚨 Impact Analysis

✅ Checklist

Uh oh!

github-actions bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MaximilianSoerenPollak left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RolandJentschETAS Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlexanderLanin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

RolandJentschETAS commented Jan 20, 2026 •

edited

Loading

github-actions bot commented Jan 20, 2026 •

edited

Loading

RolandJentschETAS Jan 20, 2026 •

edited

Loading