Skip to content

chore: Add SapMachine to ${{ matrix.distribution }} (sync fork frist) - #7

Open
skateball wants to merge 11 commits into
eclipse-sailing-analytics:mainfrom
skateball:main
Open

chore: Add SapMachine to ${{ matrix.distribution }} (sync fork frist)#7
skateball wants to merge 11 commits into
eclipse-sailing-analytics:mainfrom
skateball:main

Conversation

@skateball

@skateball skateball commented Jan 20, 2025

Copy link
Copy Markdown

Hi Colleagues,

this fork ran out of sync. Please

  1. update/sync this fork and
  2. afterwards implement this PR to add sapmachine to ${{ matrix.distribution }}

Regards Christian@SapMachine Team

@skateball skateball changed the title ci: Migrate from Temurin 8 to SapMachine 17 chore: Switch from Temurin 8 to SapMachine 11 Jan 23, 2025
@skateball skateball changed the title chore: Switch from Temurin 8 to SapMachine 11 chore: Add SapMachine to ${{ matrix.distribution }} (sync fork frist) Feb 4, 2025
@axeluhl

axeluhl commented Feb 19, 2025

Copy link
Copy Markdown

@skateball, thanks for your PR. It seems you're trying to make the build use newer versions of the JVM for building and testing. This fork is used primarily for the SAP/sailing-analytics project where the production runtime is still mostly SAP JVM 8, while Java 17 is also used for building and testing regularly (see its docker-17 branch).

Furthermore, the fork's essential contribution is the change in RPC serialization policy, see gwtproject#9779. Since that PR wasn't accepted by the GWT maintainers but we feel we need it for our production landscape, we need to live off the fork. We do not currently have the ambition nor the bandwidth to keep the fork up to date with the latest developments in the gwtproject/gwt repo. If you feel you could contribute here then that would be great.

However, newer GWT standard releases have dropped support for Java 8, hence we wouldn't be able to use it in our current production environment anyhow.

I suggest you at least add Java 8 to the matrix, adjusting your comment changes in full-check.yml accordingly.

@axeluhl

axeluhl commented Dec 3, 2025

Copy link
Copy Markdown

FYI, we recently have updated our fork to the upstream 2.12.2 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants