Add support for line background to sticky scrolling#3844
Add support for line background to sticky scrolling#3844wahlbrink wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
wahlbrink
force-pushed
the
stickyscroll-linebackground
branch
from
35bb7ad to
e4489cf
Compare
Christopher-Hermann
left a comment
Christopher-Hermann
left a comment
There was a problem hiding this comment.
Coding looks good, thanks. But I guess you need to update the version in the manifest org.eclipse.ui.editors to 3.23.0 since the interface has changed
In 2026-03/4.39 the version of The APITools-check criticizes that an method was added to an interface (and wants to increment the major version -> 4.x). Does this rule also apply to added default methods? |
Yes. You can add default methods in interface, no major bump is needed, but please "mute" the error in the IDE by adding API filter (and add the changed filter to the PR). |
It’s also permissible to create a commented filter for such an error(using a quickfix in the IDE). I’ve not looked in detail at the changes. To me that seems better, but it’s good to get a second opinion. Not sure who. do you have an opinion or know whom best to ask? |
|
I was slower on my iPhone. It looks like @iloveeclipse and I agree on a filter. Thanks for tackling this issue! |
I believe I've answered already but you've missed my comment? |
I think we need a synchronized block around the comment authoring method. 🤪 |
Some text editors uses line background to style the editor's text. This change adds support to specify the line background of sticky lines too, so that they can be styled like in the editor.
wahlbrink
force-pushed
the
stickyscroll-linebackground
branch
from
e4489cf to
12f1ef1
Compare
4 participants
Some text editors, like EGit's unified diff viewer, uses line background to style the editor's text. This change adds support to specify the line background of sticky lines too, so that they can be styled like in the editor.