Skip to content

Conversation

@tmssngr
Copy link
Contributor

@tmssngr tmssngr commented Oct 1, 2025

Inlined sendOrPost for this special case making it more obvious that an (immediate) sendEvent is happening.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Test Results

  115 files  + 4    115 suites  +4   12m 20s ⏱️ - 5m 21s
4 616 tests +19  4 598 ✅ +17  18 💤 +3  0 ❌  - 1 
  320 runs  +38    317 ✅ +36   3 💤 +2  0 ❌ ±0 

Results for commit 0f1f762. ± Comparison against base commit 63d5582.

This pull request removes 37 and adds 56 tests. Note that renamed tests count towards both.
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_dollarSign
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_emptyString
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letterA
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16LE_null
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_AsciiLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_Asciiletter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_LotsOfLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letters
…
AllWin32Tests ImageWin32Tests ‑ testDisposeDrawnImageBeforeRequestingTargetForOtherZoom
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[2] false
AllWin32Tests ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[2] false
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromCopiedImage
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromImageForImageDataFromImage
AllWin32Tests TestTreeColumn ‑ test_ColumnOrder
…
This pull request removes 2 skipped tests and adds 3 skipped tests. Note that renamed tests count towards both.
AllGTKTests Test_GtkConverter ‑ test_Heuristic_specialSingleCases
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_Heuristic_specialSingleCases
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_multipleLetters
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_unorderedCtrlC
AllWin32Tests Test_org_eclipse_swt_events_KeyEvent ‑ testEnglishUs_unpairedKeyUp
This pull request skips 2 tests.
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_setUrl_remote_with_post
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Shell ‑ test_activateEventSend

♻️ This comment has been updated with latest results.

@tmssngr tmssngr force-pushed the Control.flushQueueOnDnd-simplification branch 2 times, most recently from abe2183 to ccae0e8 Compare November 5, 2025 09:59
@tmssngr tmssngr force-pushed the Control.flushQueueOnDnd-simplification branch from ccae0e8 to 6bc5e5d Compare November 14, 2025 18:00
sendOrPost set event.data to null before sending, so keep that behavior
@tmssngr tmssngr force-pushed the Control.flushQueueOnDnd-simplification branch from 6bc5e5d to 0f1f762 Compare November 15, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants