fix: lower ArcAgentClient error log to debug and preserve cause#367
Open
sam-hey wants to merge 1 commit into
Open
fix: lower ArcAgentClient error log to debug and preserve cause#367sam-hey wants to merge 1 commit into
sam-hey wants to merge 1 commit into
Conversation
askAgent logged failed agent responses at ERROR with a full stacktrace even for expected agent failures, and dropped the original cause when rethrowing. Log at DEBUG instead and pass the cause into AgentClientException. Add a failure-path test asserting AgentClientException is thrown and the cause is preserved. Signed-off-by: Sam Heymann <sam.heymann@telekom.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ArcAgentClientService.askAgentlogs failed agent responses atERRORwith a full stacktrace, even for expected agent failures (an agent that cannot answer). This produces noisy error logs for a condition that callers already handle viaAgentClientException. It also drops the original cause when rethrowing (AgentClientException(e.message)), losing context.Change
DEBUGinstead ofERROR.throw AgentClientException(e.message, e).AgentClientExceptionis thrown and itscauseis the original exception.