Skip to content

Enable Step Filter by Default#921

Open
SougandhS wants to merge 2 commits intoeclipse-jdt:masterfrom
SougandhS:MakeDefault
Open

Enable Step Filter by Default#921
SougandhS wants to merge 2 commits intoeclipse-jdt:masterfrom
SougandhS:MakeDefault

Conversation

@SougandhS
Copy link
Copy Markdown
Member

@SougandhS SougandhS commented Mar 19, 2026

Enable Step filter and few filter options enabled by default

Fixes : #914

What it does

How to test

Author checklist

@SougandhS
Copy link
Copy Markdown
Member Author

Hi @iloveeclipse
These are the defaults now
image

@iloveeclipse
Copy link
Copy Markdown
Member

These are the defaults now

If I start debugger on any simple class, I see that "Use Step Filters" is not enabled, even if it should be according to the new defaults:

image

@SougandhS
Copy link
Copy Markdown
Member Author

If I start debugger on any simple class, I see that "Use Step Filters" is not enabled, even if it should be according to the new defaults:

I'll check this

@SougandhS SougandhS marked this pull request as draft March 19, 2026 10:53
@SougandhS SougandhS marked this pull request as ready for review March 20, 2026 05:35
@SougandhS
Copy link
Copy Markdown
Member Author

To update toggle buttons check state, I have raised another PR in platform -> eclipse-platform/eclipse.platform#2582

@SougandhS SougandhS force-pushed the MakeDefault branch 2 times, most recently from edf971a to a6157e4 Compare March 20, 2026 13:29
@SougandhS
Copy link
Copy Markdown
Member Author

Failing tests were due to the change, updated those now 👍

@iloveeclipse
Copy link
Copy Markdown
Member

See eclipse-platform/eclipse.platform#2582 (comment).
Thes is a different issue now.

Enable Step filter and few filter options enabled by default

Fixes : eclipse-jdt#914
@SougandhS
Copy link
Copy Markdown
Member Author

eclipse-platform/eclipse.platform#2582 (comment)

Resolved this now 👍

store.setDefault(IJDIPreferencesConstants.PREF_PROMPT_DELETE_CONDITIONAL_BREAKPOINT, true);


DebugUITools.setUseStepFilters(true);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong, makes product customization impossible.

Add this line org.eclipse.debug.core/org.eclipse.debug.core.USE_STEP_FILTERS=false to pluginCustomization.ini file and start Eclipse with -pluginCustomization /path/to/pluginCustomization.ini argument (change the path to your local one).

This is supposed to disable step filtering by default, because it is the product setting.
With the line above it will not work anymore.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will check this 👍

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this change
Updated setting via eclipse-platform/eclipse.platform@b2ffdcf

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With latest change in platform, one can modify via -pluginCustomization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable step filtering options by default

2 participants