Skip to content

Enable multi-status dialog when message exceeds threshold#907

Merged
SougandhS merged 1 commit intoeclipse-jdt:masterfrom
SougandhS:MaxSize
Mar 27, 2026
Merged

Enable multi-status dialog when message exceeds threshold#907
SougandhS merged 1 commit intoeclipse-jdt:masterfrom
SougandhS:MaxSize

Conversation

@SougandhS
Copy link
Copy Markdown
Member

@SougandhS SougandhS commented Mar 12, 2026

Improve the Status Dialog by enabling a multi-status when the no. status message lines exceeds a predefined line threshold. This enhances readability.

Steps to check

  1. Select an int variable in the variables view
  2. Paste a long multiline string in the detail pane
  3. Save it (cmd+s)

Current

A huge error dialog will open, but not a scrollable one, so users can't see every messages
image

With change
A minimilistic (Multi-status) dialog will open which lets user to see all errors by scrolling
image

Scroll

What it does

How to test

Author checklist

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables switching from a large single-status error dialog to a scrollable multi-status dialog when a status message exceeds a line threshold, improving readability for long multi-line error messages in the Debug UI.

Changes:

  • Add a line-threshold check in JDIDebugUIPlugin.statusDialog(String, IStatus) and wrap long messages in a MultiStatus.
  • Add a new NLS message key/field for the multi-status summary label.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/JDIDebugUIPlugin.java Adds line counting and wraps long messages into MultiStatus before opening dialogs.
org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/DebugUIMessages.properties Adds label text used for the multi-status summary message.
org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/DebugUIMessages.java Adds the corresponding NLS field for the new message key.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@SougandhS SougandhS force-pushed the MaxSize branch 2 times, most recently from c0274eb to f1b9c3d Compare March 12, 2026 16:24
@SougandhS SougandhS requested a review from iloveeclipse March 16, 2026 01:47
@SougandhS SougandhS force-pushed the MaxSize branch 2 times, most recently from 008b12d to 9418433 Compare March 22, 2026 13:22
@SougandhS SougandhS force-pushed the MaxSize branch 2 times, most recently from ed17280 to 6130813 Compare March 26, 2026 08:31
@trancexpress
Copy link
Copy Markdown
Contributor

Can be merged from my POV.

@SougandhS
Copy link
Copy Markdown
Member Author

Thanks @trancexpress

Improve the Status Dialog by enabling a multi-status when the no. status
message lines exceeds a predefined line threshold. This enhances
readability.
@SougandhS
Copy link
Copy Markdown
Member Author

Merging this now 👍

@SougandhS SougandhS merged commit 80f607a into eclipse-jdt:master Mar 27, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants