Skip to content

Fix bug in check-headers #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tortmayr merged 1 commit into from
Mar 31, 2026
Merged

Fix bug in check-headers #1643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions dev-packages/cli/src/commands/check-header.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
********************************************************************************/
import { Option } from 'commander';
import * as fs from 'fs';
import { glob } from 'glob';
import * as minimatch from 'minimatch';
import * as readline from 'readline-sync';

Expand Down Expand Up @@ -83,14 +82,14 @@ export const CheckHeaderCommand = baseCommand() //
.option('--commit', 'When used with --autoFix, also create a git commit for the fixed files', false)
.action(checkHeaders);

export function checkHeaders(rootDir: string, options: HeaderCheckOptions): void {
export async function checkHeaders(rootDir: string, options: HeaderCheckOptions): Promise<void> {
configureExec({ silent: true, fatal: true });
cd(rootDir);
if (options.excludeDefaults) {
options.exclude.push(...DEFAULT_EXCLUDES);
}

const files = getFiles(rootDir, options);
const files = await getFiles(rootDir, options);
LOGGER.info(`Check copy right headers of ${files.length} files`);
if (files.length === 0) {
LOGGER.info('Check completed');
Expand All @@ -100,14 +99,16 @@ export function checkHeaders(rootDir: string, options: HeaderCheckOptions): void
handleValidationResults(rootDir, results, options);
}

function getFiles(rootDir: string, options: HeaderCheckOptions): string[] {
async function getFiles(rootDir: string, options: HeaderCheckOptions): Promise<string[]> {
const includePattern = `**/*.@(${options.fileExtensions.join('|')})`;
const excludePattern = options.exclude;

if (options.type === 'full') {
const result = glob.sync(includePattern, {
const { globbySync } = await import('globby');
const result = globbySync(includePattern, {
cwd: rootDir,
ignore: excludePattern
ignore: excludePattern,
gitignore: true
});
return resolveFiles(result);
}
Expand Down