[#1314] open some too restrictive methods usefull in XJC plugins dev

[laurentschoelens]

Fixes #1314

• add new static method _new for JAnnotationUse in order to create new instance
• add new method addProperty(index, prop) on CClassInfo to specify index of property when adding a property on a class (and do the missing setParent call)

[laurentschoelens]

@lukasj for review please. Thanks

[lukasj]

what is the use-case for these changes? They look wrong/unnecessary to me.

Note that:

• codemodel has almost no public constructor and all elements can be created either through static <component>.new... or by calling appropriate method on the element being modeled
• there is no public setParent in the XJC model

so both changes would bring inconsistency to current APIs

[laurentschoelens]

setParent is not called (since not available) whereas it should be here :
https://github.com/highsource/jaxb-tools/blob/6eb2982b5cb692b0f20e20ccc9f43876c053c0ce/jaxb-plugins-parent/jaxb-plugins/src/main/java/org/jvnet/jaxb/plugin/simplify/SimplifyPlugin.java#L367

[lukasj]

there seems to be CClassInfo which one can pass to that method and call cclassInfo.addProperty(...) - isn't that what is wanted?

[laurentschoelens]

addProperty

Maybe we should add a addProperty with index property for that kind of usage but it could be done this way indeed

[laurentschoelens]

what is the use-case for these changes? They look wrong/unnecessary to me.

Note that:

* codemodel has almost no public constructor and all elements can be created either through static `<component>.new...` or by calling appropriate method on the element being modeled

* there is no public `setParent` in the XJC model

so both changes would bring inconsistency to current APIs

updated PR according to your remarks

[lukasj]

• changes in CClassInfo look good
• can you remind me why is _new(JClass clazz): JAnnotationUse needed? Every element which can be annotated already has annotate method producing the instance of JAnnotationUse (see JAnnotatable interface)

[laurentschoelens]

• changes in CClassInfo look good
• can you remind me why is _new(JClass clazz): JAnnotationUse needed? Every element which can be annotated already has annotate method producing the instance of JAnnotationUse (see JAnnotatable interface)

The initial issue was to open the JAnnotationUse constructor, that's why I came with that _new method here