Skip to content

Sonarqube Fixes #1651 #1603#1652

Open
gorky wants to merge 13 commits intoeclipse-ee4j:masterfrom
j2eeguys:1603
Open

Sonarqube Fixes #1651 #1603#1652
gorky wants to merge 13 commits intoeclipse-ee4j:masterfrom
j2eeguys:1603

Conversation

@gorky
Copy link
Copy Markdown
Contributor

@gorky gorky commented Jun 20, 2022

sanddusttx and others added 9 commits February 17, 2022 09:53
eclipse-ee4j#1603
xsom/src/main/java/com/sun/xml/xsom/XSSchema.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
jxc/src/main/java/com/sun/tools/jxc/ConfigReader.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/runtime/reflect/Lister.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
xsom/src/main/java/com/sun/xml/xsom/impl/scd/SimpleCharStream.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
core/src/main/java/org/glassfish/jaxb/core/marshaller/Messages.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xsom/src/main/java/com/sun/xml/xsom/impl/parser/SAXParserFactoryAdaptor.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
core/src/main/java/org/glassfish/jaxb/core/unmarshaller/DOMScanner.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
codemodel/codemodel/src/main/java/com/sun/codemodel/JAnnotationArrayMember.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/runtime/Coordinator.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]

Signed-off-by: Sanddust <sanddust@j2eeguys.com>
Also-by: Stephen Davidson <steve@j2eeguys.com>
eclipse-ee4j#1603
Updated copyrights in modified files.

Signed-off-by: Stephen Davidson <steve@j2eeguys.com>
eclipse-ee4j#1603
Fixed version in @deprecated annotations.

Signed-off-by: Steve Davidson <steve@j2eeguys.com>
Signed-off-by: Steve Davidson <steve@j2eeguys.com>
eclipse-ee4j#1603
Automatic updates
https://jenkins.updater.j2eeguys.com/
txw/runtime/src/main/java/com/sun/xml/txw2/output/IndentingXMLFilter.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
codemodel/codemodel/src/main/java/com/sun/codemodel/JCodeModel.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/model/impl/EnumLeafInfoImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/model/nav/NavigatorImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/runtime/XMLSerializer.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
codemodel/codemodel/src/main/java/com/sun/codemodel/JClassContainer.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/model/Model.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/api/SchemaCompiler.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xsom/src/main/java/com/sun/xml/xsom/XSDeclaration.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
codemodel/codemodel/src/main/java/com/sun/codemodel/JDefinedClass.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/model/impl/ElementInfoImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/model/CElementInfo.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/model/CBuiltinLeafInfo.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
external/rngom/src/main/java/com/sun/tools/rngom/ast/builder/IncludedGrammar.java
    Remove this unused import 'com.sun.tools.rngom.parse.Parseable'. [java:S1128]
xsom/src/main/java/com/sun/xml/xsom/impl/ElementDecl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
external/rngom/src/main/java/com/sun/tools/rngom/parse/compact/UCode_UCodeESC_CharStream.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/model/CClassInfo.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
txw/runtime/src/main/java/com/sun/xml/txw2/output/IndentingXMLStreamWriter.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
core/src/main/java/org/glassfish/jaxb/core/marshaller/DataWriter.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/model/CEnumLeafInfo.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/api/JAXBModel.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/model/impl/ClassInfoImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
core/src/main/java/org/glassfish/jaxb/core/annotation/XmlIsSet.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
codemodel/codemodel/src/main/java/com/sun/codemodel/JPrimitiveType.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xsom/src/main/java/com/sun/xml/xsom/impl/parser/SAXParserFactoryAdaptor.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xsom/src/main/java/com/sun/xml/xsom/impl/ParticleImpl.java
    Remove this unused import 'com.sun.xml.xsom.ForeignAttributes'. [java:S1128]
xjc/src/main/java/com/sun/tools/xjc/model/AbstractCTypeInfoImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/model/impl/LeafInfoImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/model/impl/ArrayInfoImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/model/impl/BuiltinLeafInfoImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/runtime/unmarshaller/UnmarshallerImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
codemodel/codemodel/src/main/java/com/sun/codemodel/JPackage.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/reader/gbind/Element.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/model/CPropertyInfo.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/model/impl/AnyTypeImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
codemodel/codemodel/src/main/java/com/sun/codemodel/JAnnotationUse.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
core/src/main/java/org/glassfish/jaxb/core/marshaller/SAX2DOMEx.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
txw/runtime/src/main/java/com/sun/xml/txw2/output/DataWriter.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/DatatypeConverterImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/XJCBase.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
external/relaxng-datatype/src/main/java/com/sun/tools/rngdatatype/helpers/DatatypeLibraryLoader.java
    Remove this unused import 'java.io.UnsupportedEncodingException'. [java:S1128]
codemodel/codemodel-annotation-compiler/src/main/java/com/sun/codemodel/ac/ACTask.java
    Remove this unused import 'java.net.MalformedURLException'. [java:S1128]
    Remove this unused import 'java.net.URL'. [java:S1128]
xsom/src/main/java/com/sun/xml/xsom/impl/DeclarationImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/ContextFactory.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xsom/src/main/java/com/sun/xml/xsom/XSElementDecl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
external/rngom/src/main/java/com/sun/tools/rngom/parse/compact/JavaCharStream.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]

Also-by: Stephen Davidson <steve@j2eeguys.com>
Signed-off-by: Honor Systems Updater Jenkins <hsujenkins@j2eeguys.com>
@gorky gorky mentioned this pull request Jun 20, 2022
sanddusttx and others added 4 commits July 5, 2022 17:07
eclipse-ee4j#1651
Use List, DeQueue, LinkedList and Hashmap rather than synchronized Stack, Vector, and Hashtable.
With assist from the Honor Systems Updater.

Also-by: Stephen Davidson <steve@j2eeguys.com>
Signed-off-by: Sanddust <sanddust@j2eeguys.com>
eclipse-ee4j#1651
Automatic updates
https://jenkins.updater.j2eeguys.com/
txw/runtime/src/main/java/com/sun/xml/txw2/output/IndentingXMLFilter.java
    Replace the synchronized class "Stack" by an unsynchronized one such as "Deque". [java:S1149]
external/rngom/src/main/java/com/sun/tools/rngom/parse/xml/DtdContext.java
    Replace the synchronized class "Hashtable" by an unsynchronized one such as "HashMap". [java:S1149]
xsom/src/main/java/com/sun/xml/xsom/impl/parser/state/NGCCRuntime.java
    Replace the synchronized class "Stack" by an unsynchronized one such as "Deque". [java:S1149]
    Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder". [java:S1149]
xsom/src/main/java/com/sun/xml/xsom/impl/parser/ParserContext.java
    Replace the synchronized class "Vector" by an unsynchronized one such as "ArrayList" or "LinkedList". [java:S1149]
xjc/src/main/java/com/sun/tools/xjc/reader/dtd/TDTDReader.java
    Replace the synchronized class "Stack" by an unsynchronized one such as "Deque". [java:S1149]
jxc/src/main/java/com/sun/tools/jxc/gen/config/NGCCRuntime.java
    Replace the synchronized class "Stack" by an unsynchronized one such as "Deque". [java:S1149]
    Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder". [java:S1149]
external/relaxng-datatype/src/main/java/com/sun/tools/rngdatatype/helpers/StreamingValidatorImpl.java
    Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder". [java:S1149]
xsom/src/main/java/com/sun/xml/xsom/impl/scd/SCDParser.java
    Remove this unused import 'java.util.LinkedList'. [java:S1128]
txw/compiler/src/main/java/com/sun/tools/txw2/model/XmlNode.java
    Replace the synchronized class "Stack" by an unsynchronized one such as "Deque". [java:S1149]
xjc/src/main/java/com/sun/tools/xjc/reader/relaxng/TypePatternBinder.java
    Replace the synchronized class "Stack" by an unsynchronized one such as "Deque". [java:S1149]
txw/runtime/src/main/java/com/sun/xml/txw2/output/SaxSerializer.java
    Replace the synchronized class "Stack" by an unsynchronized one such as "Deque". [java:S1149]
txw/compiler/src/main/java/com/sun/tools/txw2/NameUtil.java
    Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder". [java:S1149]
xjc/src/main/java/com/sun/tools/xjc/reader/xmlschema/ClassSelector.java
    Replace the synchronized class "Stack" by an unsynchronized one such as "Deque". [java:S1149]
txw/runtime/src/main/java/com/sun/xml/txw2/output/IndentingXMLStreamWriter.java
    Replace the synchronized class "Stack" by an unsynchronized one such as "Deque". [java:S1149]
core/src/main/java/org/glassfish/jaxb/core/marshaller/DataWriter.java
    Replace the synchronized class "Stack" by an unsynchronized one such as "Deque". [java:S1149]
txw/runtime/src/main/java/com/sun/xml/txw2/output/DomSerializer.java
    Replace the synchronized class "Stack" by an unsynchronized one such as "Deque". [java:S1149]
external/rngom/src/main/java/com/sun/tools/rngom/binary/SchemaBuilderImpl.java
    Remove this unused import 'java.util.Enumeration'. [java:S1128]
core/src/main/java/org/glassfish/jaxb/core/v2/util/XmlFactory.java
    Disable access to external entities in XML parsing. [java:S2755]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/runtime/ContentHandlerAdaptor.java
    Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder". [java:S1149]
xsom/src/main/java/com/sun/xml/xsom/util/DomAnnotationParserFactory.java
    Disable access to external entities in XML parsing. [java:S2755]
xjc/src/main/java/com/sun/tools/xjc/reader/xmlschema/DefaultParticleBinder.java
    Replace the synchronized class "Hashtable" by an unsynchronized one such as "HashMap". [java:S1149]
core/src/main/java/org/glassfish/jaxb/core/marshaller/SAX2DOMEx.java
    Replace the synchronized class "Stack" by an unsynchronized one such as "Deque". [java:S1149]
xsom/src/main/java/com/sun/xml/xsom/parser/XmlFactory.java
    Disable access to external entities in XML parsing. [java:S2755]
txw/runtime/src/main/java/com/sun/xml/txw2/output/DataWriter.java
    Replace the synchronized class "Stack" by an unsynchronized one such as "Deque". [java:S1149]
xsom/src/main/java/com/sun/xml/xsom/impl/parser/state/SimpleType_Union.java
    Replace the synchronized class "Vector" by an unsynchronized one such as "ArrayList" or "LinkedList". [java:S1149]
xsom/src/main/java/com/sun/xml/xsom/impl/SchemaSetImpl.java
    Replace the synchronized class "Vector" by an unsynchronized one such as "ArrayList" or "LinkedList". [java:S1149]
xjc/src/main/java/com/sun/tools/xjc/reader/dtd/bindinfo/BIUserConversion.java
    Disable access to external entities in XML parsing. [java:S2755]

Also-by: Stephen Davidson <steve@j2eeguys.com>
Signed-off-by: Honor Systems Updater Jenkins <hsujenkins@j2eeguys.com>
@gorky
Copy link
Copy Markdown
Contributor Author

gorky commented Nov 9, 2022

Failing check was JavaDoc generation on a package-info file, which wasn't something that was modified by this commit. Should I update from the master and resubmit?

@nros
Copy link
Copy Markdown
Contributor

nros commented Aug 2, 2023

@gorky Please update from master! I would appreciate it!

@gorky
Copy link
Copy Markdown
Contributor Author

gorky commented Aug 14, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants