Conversation
be47782 to
918b646
Compare
|
Docker image build succeeded: quay.io/eclipse/che-server:pr-968 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/cheServer/deployment", "value": {containers: [{image: "quay.io/eclipse/che-server:pr-968", name: che}]}}]" |
|
/retest |
| # Separate multiple values with comma, for example: scope,scope,scope | ||
| # The full list of scopes: https://learn.microsoft.com/en-us/azure/devops/integrate/get-started/authentication/oauth?view=azure-devops#scopes | ||
| che.integration.azure.devops.application_scopes=vso.code_write | ||
| che.integration.azure.devops.application_scopes=499b84ac-1321-427f-aa17-267ca6975798/vso.code_write |
There was a problem hiding this comment.
Magic number, do we have the source of them?
There was a problem hiding this comment.
Entra ID v2.0 requires Azure DevOps App ID URI in the scope, which is 499b84ac-1321-427f-aa17-267ca6975798 see https://learn.microsoft.com/en-us/answers/questions/5807316/invalid-scope-error-on-oidc-token-request
There was a problem hiding this comment.
Could you pls add that link to che.properties?
...azure-devops/src/main/java/org/eclipse/che/security/oauth/AzureDevOpsOAuthAuthenticator.java
Show resolved
Hide resolved
...vops/src/main/java/org/eclipse/che/security/oauth/AzureDevOpsOAuthAuthenticatorProvider.java
Show resolved
Hide resolved
|
Docker image build succeeded: quay.io/eclipse/che-server:pr-968 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/cheServer/deployment", "value": {containers: [{image: "quay.io/eclipse/che-server:pr-968", name: che}]}}]" |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tolusha, vinokurig The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What does this PR do?
Apply Microsoft Azure OIDC Authentication flow
DO NOT MERGE until eclipse-che/che-operator#2097 is merged
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23505
How to test this PR?
quay.io/eclipse/che-server:pr-968See: workspace starts, project is cloned. Token is added to the user namespace.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.