chore: Remove old devworkspace controller

[tolusha]

What does this PR do?

• Deleted controllers/devworkspace/controller.go — the old DevWorkspace routing controller and its reconciliation logic
• Moved base domain reconciliation logic into pkg/deploy/server/basedomain_reconciler.go

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

Both controllers called r.client.Status().Update(ctx, cluster) on the same CR. Because Kubernetes uses optimistic concurrency, when both controllers try to update the same object around the same time, one gets a conflict
error (the object has been modified; please apply your changes to the latest version). This leads to unnecessary reconciliation retries, flickering status, and potential race conditions where one controller's status
update overwrites the other's.

How to test this PR?

1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh

or

build/scripts/docker-run.sh /bin/bash -c "
  oc login \
    --token=<...> \
    --server=<...> \
    --insecure-skip-tls-verify=true && \
  build/scripts/olm/test-catalog-from-sources.sh
"

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh

Common Test Scenarios

• Deploy Eclipse Che
• Start an empty workspace
• Open terminal and build/run an image
• Stop a workspace
• Check operator logs for reconciliation errors or infinite reconciliation loops

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[tolusha]

/retest

[tolusha]

/retest

[tolusha]

/retest

[tolusha]

/retest

[tolusha]

ci/prow/v19-devworkspace-happy-path local run:

...
9 passing (6m)

[tolusha]

/retest

[tolusha]

/retest

[tolusha]

/retest

[tolusha]

/retest

[tolusha]

/retest

[tolusha]

/retest

[tolusha]

/retest

[tolusha]

/retest

[tolusha]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkwon17, rohanKanojia, tolusha

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tolusha]

/retest