Conversation
b66900d to
a70caf0
Compare
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1477 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1477", name: che-dashboard}]}}]" |
2 similar comments
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1477 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1477", name: che-dashboard}]}}]" |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1477 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1477", name: che-dashboard}]}}]" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1477 +/- ##
=======================================
Coverage 93.14% 93.14%
=======================================
Files 562 562
Lines 54143 54143
Branches 4077 4078 +1
=======================================
Hits 50434 50434
Misses 3665 3665
Partials 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8deb5fc to
c133df1
Compare
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1477 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1477", name: che-dashboard}]}}]" |
1 similar comment
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1477 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1477", name: che-dashboard}]}}]" |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1477 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1477", name: che-dashboard}]}}]" |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1477 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1477", name: che-dashboard}]}}]" |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, dkwon17, olexii4, svor The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1477 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1477", name: che-dashboard}]}}]" |
|
New changes are detected. LGTM label has been removed. |
…kage Assisted-by: Cursor Signed-off-by: Oleksii Orel <oorel@redhat.com>
…npm package Signed-off-by: Oleksii Orel <oorel@redhat.com>
…m package Hermeto (the Red Hat hermetic build tool) does not support Git or Exec dependencies for Yarn Berry. The previous reference: license-tool@https://github.com/che-incubator/dash-licenses.git#c09f697 caused the devspaces hermeto fetch-deps step to fail with: UnsupportedFeature: Found 1 unsupported dependencies Replace the Git URL with the published npm package @eclipse-che/license-tool@^2.0.0. The bin name (license-tool) is unchanged so the license:check and license:generate scripts continue to work without modification. Note: run `yarn install` after @eclipse-che/license-tool is published to npm to fill in the checksum in yarn.lock. Signed-off-by: Oleksii Orel <oorel@redhat.com>
Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>
Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1477 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1477", name: che-dashboard}]}}]" |
Update .deps for @fastify/http-proxy@11.4.4, @fastify/reply-from@12.6.2, and @webassemblyjs/helper-buffer@1.14.1 unresolved dependencies. Assisted-by: Claude Sonnet 4.5 Signed-off-by: Oleksii Orel <oorel@redhat.com>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1477 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1477", name: che-dashboard}]}}]" |
|
/retest |
|
@olexii4: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What does this PR do?
Replaces the container-based
dash-licensestool (quay.io/che-incubator/dash-licenses:next) with the newlicense-toolNode.js library.The
che-incubator/dash-licensesrepository has been transformed from a Docker-only tool into a pure Node.js library with ClearlyDefined API and Eclipse IP DB (JAR fallback) support. This PR integrates it directly as an npm dependency, eliminating the need for Docker/Podman to run license checks.Key Changes:
license-toolGitHub dependency — Addedlicense-toolas a devDependency inpackages/dashboard-frontend/package.json, pointing to"@eclipse-che/license-tool": "^2.0.0"license:checkscript — Changed from$PWD/scripts/container_tool.sh run --rm -t -v $PWD/:/workspace/project:Z quay.io/che-incubator/dash-licenses:next --check --batch 200tolicense-tool --checklicense:generatescript — Changed from container invocation tolicense-tool --harvest.deps/files — Updatedprod.md,dev.md,EXCLUDED/prod.md, andEXCLUDED/dev.mdwith fresh license data from ClearlyDefined API and Eclipse IP DB JAR fallbackBenefits:
yarn license:checkout of the boxScreenshot/screencast of this PR
N/A — infrastructure/tooling change, no UI changes.
What issues does this PR fix or reference?
It needs for eclipse-che/che#23756
Is it tested? How?
yarn license:generatefrom the project rootproblems.mdshould not be generatedyarn license:checkto verify the check mode works.deps/prod.mdand.deps/dev.mdcontain proper license tablesRelease Notes
Docs PR