-
Notifications
You must be signed in to change notification settings - Fork 0
Vendor jupyter-dark-detect to simplify conda-forge packaging #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #121 +/- ##
===========================================
+ Coverage 82.26% 82.93% +0.67%
===========================================
Files 88 89 +1
Lines 5451 5461 +10
Branches 454 453 -1
===========================================
+ Hits 4484 4529 +45
+ Misses 802 761 -41
- Partials 165 171 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request vendors the jupyter-dark-detect package into the codebase to simplify conda-forge packaging by eliminating an external dependency. The PR also updates copyright years from 2025 to 2026 across all source files and adds a custom wrapper module with a modified detection order optimized for EasyDiffraction's use case.
Key changes:
- Vendors
jupyter-dark-detectpackage undersrc/easydiffraction/utils/_vendored/jupyter_dark_detect/ - Adds custom
theme_detectwrapper module with detection order: JupyterLab settings → VS Code settings → JavaScript DOM → System preferences - Updates import from
jupyter_dark_detectto the vendoredeasydiffraction.utils._vendored.theme_detectin production code - Removes
jupyter_dark_detectdependency frompyproject.tomlwhile keepingdarkdetectfor system-level detection
Reviewed changes
Copilot reviewed 208 out of 208 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/easydiffraction/utils/_vendored/jupyter_dark_detect/* |
Vendored copy of upstream jupyter-dark-detect package with detector logic |
src/easydiffraction/utils/_vendored/theme_detect.py |
Custom wrapper implementing modified detection priority order |
src/easydiffraction/utils/_vendored/__init__.py |
Documentation for vendored code with update instructions |
src/easydiffraction/display/tablers/base.py |
Updated import to use vendored theme_detect module |
tests/unit/easydiffraction/utils/test_theme_detect.py |
Comprehensive test suite for vendored theme detection functionality |
tools/update_spdx.py |
Added exclusion pattern for vendored code to skip SPDX updates |
pyproject.toml |
Removed jupyter_dark_detect dependency and added ruff lint exceptions for vendored code |
tmp/display3.py |
Example/temporary file showing usage of vendored theme_detect |
| All other files | Copyright year updated from 2025 to 2026 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
No description provided.