Skip to content

Comments

Update documentation for CARAVAN_CACHE variable#495

Merged
MarkMelotto merged 9 commits intomainfrom
MarkMelotto-patch-caravan
Feb 19, 2026
Merged

Update documentation for CARAVAN_CACHE variable#495
MarkMelotto merged 9 commits intomainfrom
MarkMelotto-patch-caravan

Conversation

@MarkMelotto
Copy link
Contributor

Clarify the environmental variable path for CARAVAN_CACHE.

It is nice to know how to actually use it :)

Clarify the environmental variable path for CARAVAN_CACHE.
@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.17%. Comparing base (b594838) to head (ab6bbd5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   79.17%   79.17%           
=======================================
  Files          28       28           
  Lines        1882     1882           
  Branches      168      168           
=======================================
  Hits         1490     1490           
  Misses        330      330           
  Partials       62       62           
Files with missing lines Coverage Δ
src/ewatercycle/_forcings/caravan.py 83.01% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Update the path for CARAVAN_CACHE environmental variable.
Updated the example path for CARAVAN_CACHE in documentation.
@MarkMelotto
Copy link
Contributor Author

@BSchilperoort when you have time, please take a look, should not take more than a minute!

Copy link
Member

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a more generic way to put it I think. Not every ewatercycle setup needs to have dcache, it's just what we use because it's the most convenient thing SURF offers for this.

MarkMelotto and others added 3 commits February 19, 2026 10:24
Co-authored-by: Bart Schilperoort <b.schilperoort@esciencecenter.nl>
@MarkMelotto
Copy link
Contributor Author

MarkMelotto commented Feb 19, 2026

@BSchilperoort there is this new rule that wants to change lines like:
dataset: str = basin_id.split("_")[0]

to:

parts = basin_id.split("_")
dataset = parts[0]

I think that makes readability worse, so quick check if you agree

@BSchilperoort
Copy link
Member

@BSchilperoort there is this new rule that wants to change lines like: dataset: str = basin_id.split("_")[0]

to:

parts = basin_id.split("_")
dataset = parts[0]

I think that makes readability worse, so quick check if you agree

I agree!

@MarkMelotto MarkMelotto merged commit 58509f4 into main Feb 19, 2026
6 checks passed
@MarkMelotto MarkMelotto deleted the MarkMelotto-patch-caravan branch February 19, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants