Fix live Java checks and Temurin discovery#103
Merged
Conversation
…vm_path into subprocess
Make Temurin version discovery asset-backed, isolate rJava version checks via subprocess env setup, and update tests and CI diagnostics for the live workflow.
# Conflicts: # R/java_env.R # tests/testthat/test-java_env_subprocess_regression.R
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 89.12% 89.53% +0.41%
==========================================
Files 27 27
Lines 2776 2887 +111
==========================================
+ Hits 2474 2585 +111
Misses 302 302 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden Temurin version discovery by validating the summary endpoint response and confirming majors against downloadable Temurin assets.
Rework rJava version checks to use a shared subprocess Java environment, prefer
callrwhen available, and keep anRscriptfallback with the same env contract.Update the live-test workflow and test suite so package behavior, subprocess isolation, and Temurin fallback paths are covered consistently.
Verification
Run
Rscript -e 'devtools::test(stop_on_failure = FALSE)'Expected local result:
[ FAIL 0 | WARN 0 | SKIP 61 | PASS 519 ]