Skip to content

Conversation

@nirmit-damania-dyno
Copy link
Collaborator

This PR adds a validation rule to BaseModel which raises a ValueError on class init if columns exist with duplicate names. For example...

class Testschema(BaseModel, CustomEntityMixin):
    __schema_properties__ = ...

    test = Column(name="Test", type=BenchlingFieldType.INTEGER, required=False)
    test_two = Column(name="Test", type=BenchlingFieldType.INTEGER, required=False)

raises: ValueError: Schema cannot have fields with duplicate Column names. when running from ..schemas.entity_schemas import *

@nirmit-damania-dyno nirmit-damania-dyno added type:minor-enhancement New minor feature or request semver:patch A backwards compatible bug fix (patch version bump) labels Jan 5, 2026
@nirmit-damania-dyno nirmit-damania-dyno merged commit 95dd3a5 into main Jan 5, 2026
4 checks passed
@nirmit-damania-dyno nirmit-damania-dyno deleted the validation-for-schema-with-duplicate-field-names branch January 5, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch A backwards compatible bug fix (patch version bump) type:minor-enhancement New minor feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants