separate entity links from CreateEntitySchema #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirmit-damania-dyno
added
type:minor-enhancement
nirmit-damania-dyno
deleted the
schema-compare-separate-entity-link-from-create-schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates out setting entity_link when creating an Entity Schema to happen in separate UpdateEntitySchemaField operations. This solves the issue of potential circular dependencies when creating multiple entity schemas.
If two schemas are attempted to be created in the same migration with entity_links that depend on each other, this would fail. Now, this migration works successfully since the two entity schemas are created without the entity_links, then they are set.