Bug schema compare naming strategies #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirmit-damania-dyno
added
type:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
fixes a bug where if the naming strategies are only template based, the migration fails since it attempts to create an entity schema with no naming strategies which is not allowed. Now, a temporary naming strategy is set in CreateEntitySchema with non-template-based strategies.
Fixes a bug in UpdateEntitySchemaNameTemplate where since it is ordered to be before UpdateEntitySchema, the schema name UpdateEntitySchemaNameTemplate points to should be the benchling_given_wh_name, in case the schema wh_name changes after.
The test is updated because it is expected that the compare wh_name key is the actual name, not the benchling given name. This was happening before because set_warehouse_name was happening pre model_dump, which was a bug.