Skip to content

Conversation

@nirmit-damania-dyno
Copy link
Collaborator

@nirmit-damania-dyno nirmit-damania-dyno commented Dec 30, 2025

This PR updates the docs and removes some unnecessary print statements. Also, if naming_strategies is unset, the default is now below, and is based on Benchling's default when first creating a new entity schema

{
        BenchlingNamingStrategy.NEW_IDS,
        BenchlingNamingStrategy.IDS_FROM_NAMES,
        BenchlingNamingStrategy.REPLACE_NAME_WITH_ID,
}
Screenshot 2026-01-04 at 3 40 08 PM

If desired, entity schemas in code can now clean up the code a bit if the naming strategy is the default

@nirmit-damania-dyno nirmit-damania-dyno added semver:patch A backwards compatible bug fix (patch version bump) type:documentation Improvements or additions to documentation type:minor-enhancement New minor feature or request labels Dec 30, 2025
@nirmit-damania-dyno nirmit-damania-dyno merged commit f6aad3b into main Jan 4, 2026
4 checks passed
@nirmit-damania-dyno nirmit-damania-dyno deleted the bug-naming-strategy-for-new-entity-schema branch January 4, 2026 20:42
@nirmit-damania-dyno nirmit-damania-dyno removed the type:documentation Improvements or additions to documentation label Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch A backwards compatible bug fix (patch version bump) type:minor-enhancement New minor feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants