bug new dropdown used in schema #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirmit-damania-dyno
added
semver:patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the lru_cache from
get_benchling_dropdown_summaries. This function is used during operation execution to get the list of dropdowns. However, by being cached, this was causing bugs by operations later on in the timeline working off of outdated dropdown informationFor example, let's say in a revision file, a new dropdown is created, and then that dropdown is added to an entity schema field. This revision file migration would fail since the 2nd operation would call the cached dropdown information and not see the new dropdown info present