Admin governance: remove the admin_governance feature flag - #29637
Open
philipperolet wants to merge 2 commits into
Open
Admin governance: remove the admin_governance feature flag#29637philipperolet wants to merge 2 commits into
philipperolet wants to merge 2 commits into
Conversation
Admin governance ships to all workspaces: drop the flag, keep the governance rendering everywhere, and delete the legacy Workspace Settings page tree that becomes unreachable.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
![dust-agent[bot]](https://avatars.githubusercontent.com/in/1117438?s=60&v=4){kind=small}
Contributor
|
philipperolet
added
sdk-ack
…v matcher - Port WorkspaceDefaultAgentPicker to the governance page (Features section), still gated by the workspace_default_agent flag: two workspaces use it without admin_governance and would have lost the UI. - Redirect the legacy /w/[wId]/workspace route to /governance. - Drop the stale /w/[wId]/workspace pattern from the Admin tab matcher.
philipperolet
commented
Jul 28, 2026
| selectedRole, | ||
| isAdminGovernanceEnabled | ||
| ); | ||
| // `builder` is deprecated: display it as a regular member. |
Contributor
Author
There was a problem hiding this comment.
this and other related comms can be removed on the PR cleaning isBuilder for good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Admin governance ships to all workspaces: this removes the
admin_governancefeature flag and every check on it, keeping the flag-enabled behavior everywhere.End-user changes for workspaces that did not have the flag:
/w/[wId]/workspacenow redirects to/w/[wId]/governance. "Identity & Provisioning" is now labeled "IT & Security".managerrole can now be assigned and invited, and thedust-managersprovisioning group grants it;buildercan no longer be assigned from the role dropdown (existing builders display as members).Code notes:
ContextItemvariants of the settings toggles).workspace_default_agentflag, used by 2 workspaces withoutadmin_governance) is ported to the governance page's Features section instead of being deleted with the legacy page.admin_governance_skill_publicationis a separate flag and is untouched.buildersOnlyplumbing inManageUsersPanel/MemberSelectionTableno longer has callers; left for the builder-deprecation cleanup series.admin_governancerows infeature_flagsare ignored at read time (FeatureFlagResource.listForWorkspacefilters on the whitelist), so no migration is needed.Follow-up candidates:
restrict_agents_publishing(_to_admins)flags (their info-only row lived on the legacy page; enforcement is unchanged).Risks
Blast radius: all workspace admin surfaces for workspaces without the flag (settings/governance pages, members & invitations, role provisioning, nav).
Risk: standard
Deploy Plan
admin_governancerows fromfeature_flags