Draft
Conversation
fed-franz
force-pushed
the
improve-outofsync
branch
from
459291e to
9936174
Compare
fed-franz
force-pushed
the
improve-outofsync
branch
from
9936174 to
25b81d4
Compare
autholykos
approved these changes
Sep 28, 2024
Member
autholykos
left a comment
autholykos
left a comment
There was a problem hiding this comment.
LGTM (just a very little nit that can be ignored)
| @@ -461,8 +467,9 @@ impl<DB: database::DB, VM: vm::VMExecution, N: Network> | |||
|
|
|||
| if !inv.inv_list.is_empty() { | |||
Member
There was a problem hiding this comment.
nit: since we are at it, can we simply return early if inv.inv_list.is_empty() rather than nesting logic in the opposite case?
Contributor
Author
There was a problem hiding this comment.
Totally in favor!
herr-seppia
requested changes
Sep 28, 2024
| // Transit back to InSync mode | ||
| // We check the timeout here to prevent the peer from keeping us in | ||
| // outofsync by flooding our node with blocks | ||
| if self.on_sync_timeout().await { |
Member
There was a problem hiding this comment.
On_sync_timeout try to acquire a write lock from the acceptor (but you already acquired it, so probably it get stuck)
Try this before merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses unresolved comments in #2484
last_requestinrequest_pool_missing_blocks