Skip to content

[PyArrow] Filter Pushdown of IS IN now uses the dedicated pyarrow.compure.Expression.isin method #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: v1.4-andium
Choose a base branch
from
Draft

[PyArrow] Filter Pushdown of IS IN now uses the dedicated pyarrow.compure.Expression.isin method #73

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b42618
construct a list out of the values, to pass to 'pyarrow.compute.Expre…
Tishj Sep 19, 2025
a11eaad
Merge branch 'v1.4-andium' into use_pyarrow_isin
evertlammerts Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions src/duckdb_py/arrow/pyarrow_filter_pushdown.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,15 @@ py::object GetScalar(Value &constant, const string &timezone_config, const Arrow
}
}

static py::list TransformInList(const InFilter &in) {
py::list res;
ClientProperties default_properties;
for (auto &val : in.values) {
res.append(PythonObject::FromValue(val, val.type(), default_properties));
}
return res;
}

py::object TransformFilterRecursive(TableFilter &filter, vector<string> column_ref, const string &timezone_config,
const ArrowType &type) {
auto &import_cache = *DuckDBPyConnection::ImportCache();
Expand Down Expand Up @@ -282,17 +291,9 @@ py::object TransformFilterRecursive(TableFilter &filter, vector<string> column_r
}
case TableFilterType::IN_FILTER: {
auto &in_filter = filter.Cast<InFilter>();
ConjunctionOrFilter or_filter;
value_set_t unique_values;
for (const auto &value : in_filter.values) {
if (unique_values.find(value) == unique_values.end()) {
unique_values.insert(value);
}
}
for (const auto &value : unique_values) {
or_filter.child_filters.push_back(make_uniq<ConstantFilter>(ExpressionType::COMPARE_EQUAL, value));
}
return TransformFilterRecursive(or_filter, column_ref, timezone_config, type);
auto constant_field = field(py::tuple(py::cast(column_ref)));
auto in_list = TransformInList(in_filter);
return constant_field.attr("isin")(std::move(in_list));
}
case TableFilterType::DYNAMIC_FILTER: {
//! Ignore dynamic filters for now, not necessary for correctness
Expand Down