Skip to content

Remove xfail annotations on adbc tests #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

Remove xfail annotations on adbc tests #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions tests/fast/adbc/test_adbc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import datetime
import sys
from pathlib import Path

import adbc_driver_manager.dbapi
Expand Down Expand Up @@ -29,7 +28,6 @@ def example_table():
)


@xfail(sys.platform == "win32", reason="adbc-driver-manager.adbc_get_info() returns an empty dict on windows")
def test_connection_get_info(duck_conn):
assert duck_conn.adbc_get_info() != {}

Expand All @@ -42,9 +40,6 @@ def test_connection_get_table_types(duck_conn):
assert duck_conn.adbc_get_table_types() == ["BASE TABLE"]


@xfail(
sys.platform == "win32", reason="adbc-driver-manager.adbc_get_objects() returns an invalid schema dict on windows"
)
def test_connection_get_objects(duck_conn):
with duck_conn.cursor() as cursor:
cursor.execute("CREATE TABLE getobjects (ints BIGINT PRIMARY KEY)")
Expand All @@ -66,9 +61,6 @@ def test_connection_get_objects(duck_conn):
assert depth_all.schema == depth_catalogs.schema


@xfail(
sys.platform == "win32", reason="adbc-driver-manager.adbc_get_objects() returns an invalid schema dict on windows"
)
def test_connection_get_objects_filters(duck_conn):
with duck_conn.cursor() as cursor:
cursor.execute("CREATE TABLE getobjects (ints BIGINT PRIMARY KEY)")
Expand Down Expand Up @@ -207,7 +199,6 @@ def test_statement_query(duck_conn):
assert cursor.fetch_arrow_table().to_pylist() == [{"foo": 1}]


@xfail(sys.platform == "win32", reason="adbc-driver-manager returns an invalid table schema on windows")
def test_insertion(duck_conn):
table = example_table()
reader = table.to_reader()
Expand All @@ -234,7 +225,6 @@ def test_insertion(duck_conn):
assert cursor.fetch_arrow_table().to_pydict() == {"count_star()": [8]}


@xfail(sys.platform == "win32", reason="adbc-driver-manager returns an invalid table schema on windows")
def test_read(duck_conn):
with duck_conn.cursor() as cursor:
filename = Path(__file__).parent / ".." / "data" / "category.csv"
Expand Down
Loading