fix(proxy): use keyDir variable instead of string literal - #162
Open
Ajithkumar003-dev wants to merge 1 commit into
Open
fix(proxy): use keyDir variable instead of string literal#162Ajithkumar003-dev wants to merge 1 commit into
Ajithkumar003-dev wants to merge 1 commit into
Conversation
os.Stat("keyDir") checked a literal string rather than the keyDir
variable, so the CA certificate directory existence check never
evaluated the real path. The sibling check for the CA key directory
a few lines above already uses the variable correctly.
Fixes dstotijn#147
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a one-line bug in
LoadOrCreateCAwhere the CA-cert directoryexistence check used the literal string
"keyDir"instead of thekeyDirvariable.Why
This means the directory-exists check never evaluates the real path,
so
os.MkdirAllnever runs for the CA cert directory when it's missing— unlike the CA key directory check just above it, which correctly
uses the variable.
Fixes #147
Testing
go build ./pkg/proxy/andgo vet ./pkg/proxy/pass locally.