Add go.mod and go.sum files to support Go modules. #67
Conversation
In order to work well with [Go modules][1] a package should have go.mod and go.sum files and semantic version tags on release versions. This commit adds those files. No functional changes are intended. [1]: https://github.com/golang/go/wiki/Modules
|
Given this comment in the README:
I imagine |
|
Thanks for the PR. Sigh... my Travis script is messed up. It doesn't build and test hermetically |
I saw that, but I haven't yet figured out whether that's triggered by this change. I did wind up having to manually install |
It's not. The script calls |
I ran into this when trying to make a similar change in sergi/go-diff#98. I don't see any really graceful solution to it, apart from maybe vendoring a binary of golint.
It is not urgent, can wait. I'm just trying to clean up the dependencies of http://kythe.io/ so that we can use modules for our Go build. |
|
Apologies for the delay, but I finally got around to fixing the travis script. See #68. Part of the fix involved added a BTW, a tag has now been issues for |
|
Great, thanks so much. |
2 participants
In order to work well with Go modules a package should have
go.modandgo.sumfiles and semantic version tags on release versions. This commit adds those files. No functional changes are intended.Assuming you accept this change, I recommend that you also run
git tag v0.0.1 master ; git push origin v0.0.1after it is merged, to start the release history. If the API of the package is considered stable, you could instead usev1.0.0, but at that point module users will expect breaking changes to increment the major version. I don't have a clear sense of how much this package is maintained, sov0would be a safe default for now.