feat (DistributionIndexProcessor): Expose Forge properties#16
Open
GeekCornerGH wants to merge 1 commit into
Open
feat (DistributionIndexProcessor): Expose Forge properties#16GeekCornerGH wants to merge 1 commit into
GeekCornerGH wants to merge 1 commit into
Conversation
sjempotje
approved these changes
May 14, 2026
sjempotje
left a comment
sjempotje
left a comment
There was a problem hiding this comment.
LGTM overall. The current type errors are expected because the required helios-distribution-types changes (including ForgeProcessor) haven’t been merged yet.
Once that dependency update lands, the following errors in DistributionFactory.ts should resolve.
Build failure is expected for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More informations in the relevant PR: dscalzi/HeliosLauncher#396