feat(seeder): Add configurable variables for data seed#383
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support in dsw-data-seeder for configurable placeholder variables (and named UUID placeholders) that can be substituted into seed SQL scripts, with configuration exposed via recipe JSON and app config.
Changes:
- Extend seed recipe format to support
uuids.namesandvariables(placeholder + values). - Add variable/UUID placeholder replacement logic to
SeedRecipeand wire recipe loading to merge configured variables. - Introduce
seedconfiguration section (job timeout + variables) and addcast_dicthelper indsw-config.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/dsw-data-seeder/example/example.seed.json | Updates example recipe with named UUIDs and variable placeholders/values. |
| packages/dsw-data-seeder/dsw/data_seeder/seeder.py | Implements variable replacement + named UUIDs; updates recipe loading and queue timeout config lookup. |
| packages/dsw-data-seeder/dsw/data_seeder/config.py | Renames/introduces seed config keys/model and adds variables config key. |
| packages/dsw-data-seeder/config.example.yml | Documents new seed config section (jobTimeout + variables). |
| packages/dsw-config/dsw/config/keys.py | Adds cast_dict convenience caster. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
86757ef to
819097c
Compare
|
@copilot can you review again? |
Reviewed and addressed the remaining unresolved issue: |
fe996ef to
047b86e
Compare
No description provided.