Conversation
- composer.json: php ^8.3, laravel/helpers ^1.8 prod; require-dev L13.7 stack
(laravel/framework ^13.7, phpunit ^11.5.3, testbench ^11.0, mockery ^1.6,
collision ^8.6); spatie/laravel-http-logger ^1.11.2; promphp 2.x; tighten
df-core ~1.0.4; drop unused df-system require
- ServiceProvider: gate Route::pushMiddlewareToGroup('df.api', ...) with
Route::hasMiddlewareGroup() to handle non-deterministic boot order
- PredisAdapter: add no-op updateSummary() to satisfy
promphp/prometheus_client_php 2.x Adapter interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 4 of the L11→L13 upgrade campaign. Composer-only + 2 minimal source patches.
Files changed:
composer.json— full L13 dep matrix (php ^8.3, laravel/helpers ^1.8 prod, framework ^13.7 + phpunit ^11.5.3 + testbench ^11.0 + mockery ^1.6 + collision ^8.6 dev). Bumps spatie/laravel-http-logger ^1.11.2 (first L13-supporting tag), promphp ^2.14, df-core ~1.0.4. Drops unused df-system require.src/ServiceProvider.php— gateRoute::pushMiddlewareToGroup('df.api', ...)withRoute::hasMiddlewareGroup()to handle non-deterministic boot order.src/Utility/HttpLogger/PredisAdapter.php— add no-opupdateSummary()to satisfy promphp 2.xAdapterinterface (added in 2.3+).Validation
Test plan
/metricsendpoint smoke once L13 release tags landNotes
predis/predis: ~1.0constraint. Predis v2/v3 bump deferred.PredisAdapter::wipeStorage()(calls non-existentensureOpenConnection(), references\Redis::OPT_PREFIXwhich is php-redis ext, not predis) are out of scope.