fix(tracing/span): use credential_manager for storage operations - #270
Merged
briangreunke merged 1 commit intoDec 13, 2025
Merged
Conversation
briangreunke
deleted the
brian/eng-3733-bug-log_output-not-saving-to-s3
branch
December 13, 2025 17:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title: Fix Log Output Saving to S3 by Utilizing Credential Manager
Summary
This PR addresses a bug related to log output not being saved to S3 due to improper use of storage operations. The changes ensure that storage operations now correctly utilize the credential manager for handling S3-related tasks, thereby improving reliability and correctness of data saving procedures.
Changes
Bug Fixes
RunSpanclass methods to usecredential_managerinstead ofstorage_managerfor executing storage operations and retrieving storage prefixes._store_file_by_hashto callexecute_with_retryoncredential_manager._create_object_by_hashto retrieve prefix usingcredential_manager.Generated Summary:
_storage_managerwith_credential_managerin theRunSpanclass.execute_with_retryto call from_credential_managerinstead of_storage_manager._storage_manager.get_prefix()to_credential_manager.get_prefix().This summary was generated with ❤️ by rigging