Skip to content

fix(tracing/span): use credential_manager for storage operations - #270

Merged
briangreunke merged 1 commit into
feat/datasetsfrom
brian/eng-3733-bug-log_output-not-saving-to-s3
Dec 13, 2025
Merged

fix(tracing/span): use credential_manager for storage operations#270
briangreunke merged 1 commit into
feat/datasetsfrom
brian/eng-3733-bug-log_output-not-saving-to-s3

Conversation

@briangreunke

@briangreunke briangreunke commented Dec 13, 2025

Copy link
Copy Markdown
Contributor

PR Title: Fix Log Output Saving to S3 by Utilizing Credential Manager

Summary

This PR addresses a bug related to log output not being saved to S3 due to improper use of storage operations. The changes ensure that storage operations now correctly utilize the credential manager for handling S3-related tasks, thereby improving reliability and correctness of data saving procedures.

Changes

Bug Fixes

  • Storage Operations: Modified RunSpan class methods to use credential_manager instead of storage_manager for executing storage operations and retrieving storage prefixes.
    • Updated _store_file_by_hash to call execute_with_retry on credential_manager.
    • Updated _create_object_by_hash to retrieve prefix using credential_manager.

Generated Summary:

  • Replaced references to _storage_manager with _credential_manager in the RunSpan class.
  • Updated the method execute_with_retry to call from _credential_manager instead of _storage_manager.
  • Changed the way prefixes are obtained for object storage from _storage_manager.get_prefix() to _credential_manager.get_prefix().
  • These modifications may alter how credential management interacts with storage operations, potentially impacting data retrieval and storage efficiency.

This summary was generated with ❤️ by rigging

@briangreunke
briangreunke merged commit 25f066a into feat/datasets Dec 13, 2025
1 check passed
@briangreunke
briangreunke deleted the brian/eng-3733-bug-log_output-not-saving-to-s3 branch December 13, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant