chore: minor cleanups around the eval flow #6152
Merged
+31
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| string err; | ||
| Interpreter::AddResult add_res = interpreter->AddFunction(sha, script_data->body, &err); | ||
| if (add_res != Interpreter::ADD_OK) { | ||
| LOG(DFATAL) << "Error adding " << sha << " to database, err " << err; |
There was a problem hiding this comment.
If AddFunction fails here we only log and continue, which could lead to executing the script path without the function actually being registered. Consider returning an error or aborting the eval path early after this failure to avoid inconsistent runtime behavior.
🤖 Was this useful? React with 👍 or 👎
Also, fix a minor bug where script params were not flushed during "script flush" command. Signed-off-by: Roman Gershman <[email protected]>
dranikpg
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix a minor bug where script params were not flushed during
"script flush" command.
Signed-off-by: Roman Gershman [email protected]