Repository navigation
[wasm] Avoid Spilling Many GC-ref Typed Tree Temps - #135577
Draft
adamperlin wants to merge 1 commit into
Draft
adamperlin wants to merge 1 commit into
adamperlin wants to merge 1 commit into
Conversation
…by a direct parent call that is managed and non-helper
|
Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
fgWasmSpillRefspass spills all outstanding GC-ref typed temporary values, even if those temps are consumed by the most immediate managed, non-helper call. However, for a managed non-helper call, it should be the callee's responsibility to maintain GC safety of any incoming GC-ref typed args (either by spilling to a pinned stack home in the prolog or potentially avoiding spilling at all, see #135543). In the R2R fixup case, where a thunk will fix up the call target on first invocation, we should also be GC-protecting all incoming args by default (See the spilling logic in crossgen2WasmImportThunk.cs).This PR removes the need for spilling in cases like:
Where
Useis managed.Note that the spilling STILL needs to happen for nested calls, where a ref has an outstanding use which is NOT its most immediate parent.