[release/11.0] Guard against empty remote address on macOS accept - #133566
Open
github-actions[bot] wants to merge 1 commit into
Open
[release/11.0] Guard against empty remote address on macOS accept#133566github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Fixes #121848 ## Problem On macOS, when a peer connects to an `AF_INET6` listening socket and immediately resets the connection (`SO_LINGER=0`), `accept(2)` returns a valid file descriptor but leaves the remote sockaddr buffer untouched and reports `addrlen=0`. This kernel behavior was measured with a plain C repro in the [issue comment](#121848 (comment)) and does not depend on dual-mode or `IPV6_V6ONLY`. The 2024 fix (#108616) guarded the `EndPoint.Create` call inside `FinishOperationAccept` on the Unix path, but the shared `FinishOperationSyncSuccess` in [`SocketAsyncEventArgs.cs`](https://github.com/dotnet/runtime/blob/main/src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.cs#L1016) calls `Create` a second time on the same zero-sized `SocketAddress` and throws `ArgumentException`. For Kestrel this kills the accept loop permanently while the process stays alive and the port stays bound. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #131869 to release/11.0
/cc @wfurt
Customer Impact
on macOS Accept() can succeed but fails to provide remote address at the same time. We do not handle the condition right and we may end up in permanently broken state in some cases.
Regression
Testing
new test was added as Ewell as the fix was verify by customer based on the main branch fix.
Risk
low. This just checks for error and swallows the exception
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.