arm64: Reuse SVE mask constants in LSRA#131309
Open
jonathandavies-arm wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 7 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
reviewed
Jul 24, 2026
Comment on lines
+2148
to
+2157
| #if defined(TARGET_ARM64) && defined(FEATURE_MASKED_HW_INTRINSICS) | ||
| struct SveMaskIntervalEntry | ||
| { | ||
| GenTree* tree; | ||
| Interval* interval; | ||
| SveMaskIntervalEntry* next; | ||
| }; | ||
|
|
||
| SveMaskIntervalEntry* reusableSveMaskIntervals = nullptr; | ||
| #endif |
Member
There was a problem hiding this comment.
I was not expecting to see anything like this. What makes this needed over the existing constant reuse mechanism that LSRA already has? E.g. members like LinearScan::m_RegistersWithConstants and LinearScan::getMatchingConstants.
Did you figure out why the existing mechanism does not handle the cases this tries to handle? It would be good to understand that first.
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the ptrue reuse work done in LSRA instead of a new pass.