Skip to content

cdac: Fix GetModuleMetaDataFileInfo null-param handling and output initialization#131291

Closed
noahfalk with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-review-comment-3639500128
Closed

cdac: Fix GetModuleMetaDataFileInfo null-param handling and output initialization#131291
noahfalk with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-review-comment-3639500128

Conversation

Copilot AI commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

GetModuleMetaDataFileInfo was checking for null pointer params inside the try block (throwing NullReferenceException instead of returning E_POINTER) and initializing output pointers inside the try block, leaving them uninitialized on exception paths before the assignments.

  • Return HResults.E_POINTER immediately for any null pointer param, before the try block — matching the pattern of CreateHeapWalk, UnwindStackWalkFrame, and other APIs in the file
  • Move *pResult = FALSE, *dwTimeStamp = 0, *dwImageSize = 0 initializations before the try block so callers always observe defined values on failure paths

Copilot AI review requested due to automatic review settings July 23, 2026 20:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
16 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

…ize outputs up-front

Co-authored-by: noahfalk <6243776+noahfalk@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 23, 2026 20:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copilot AI changed the title [WIP] Fix code for review comment 3639500128 cdac: Fix GetModuleMetaDataFileInfo null-param handling and output initialization Jul 23, 2026
Copilot AI requested a review from noahfalk July 23, 2026 20:39
@noahfalk noahfalk closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants