Closed
cdac: Fix GetModuleMetaDataFileInfo null-param handling and output initialization#131291
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
…ize outputs up-front Co-authored-by: noahfalk <6243776+noahfalk@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Copilot
AI
changed the title
[WIP] Fix code for review comment 3639500128
cdac: Fix GetModuleMetaDataFileInfo null-param handling and output initialization
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetModuleMetaDataFileInfowas checking for null pointer params inside thetryblock (throwingNullReferenceExceptioninstead of returningE_POINTER) and initializing output pointers inside thetryblock, leaving them uninitialized on exception paths before the assignments.HResults.E_POINTERimmediately for any null pointer param, before thetryblock — matching the pattern ofCreateHeapWalk,UnwindStackWalkFrame, and other APIs in the file*pResult = FALSE,*dwTimeStamp = 0,*dwImageSize = 0initializations before thetryblock so callers always observe defined values on failure paths