[WASI] Stop generation of Node.js execution script due to lack of preview2 support #122030
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
github-actions
bot
added
the
needs-area-label
Copilot finished reviewing on behalf of
yamachu
November 28, 2025 09:36
Contributor
There was a problem hiding this comment.
Pull request overview
This PR temporarily disables the generation of Node.js execution scripts for WASI applications due to a compatibility mismatch. While .NET 9+ now supports WASI preview2, the Node.js script being generated hardcodes version: 'preview1', making it incompatible with the current runtime. The change prevents user confusion by not generating a script that cannot be used as-is.
Key Changes
- Commented out the
_WasmGenerateNodeScriptstarget invocation in the build dependency chain - Added an explanatory comment noting the temporary nature of this change pending Node.js preview2 support
jkotas
added
os-wasi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From .NET 9, wasip2 is now supported.
However, the currently available Node.js does not directly support preview2.
The generated execution script node.mjs currently specifies preview1, and as a result, it cannot be used as-is for execution.
To avoid user confusion, we are temporarily stopping the output of this file until proper support is available.