Document excerpt for Razor, and fix Find All Refs #81291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…helper to make calling it easy
davidwengier
commented
Nov 17, 2025
|
|
||
| namespace Microsoft.CodeAnalysis.Classification; | ||
|
|
||
| [DataContract] |
Member
Author
There was a problem hiding this comment.
This is public API, so let me know if this change isn't allowed, and I can create a wrapper in the EA
CyrusNajmabadi
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2633418
We had to revert some code that made FAR, Hover, Go To Def etc. work in Razor files because to support it we had to add
#linemappings for things, and that broke Hot Reload by changing PDB offsets. Who knrew!This PR enables us to bring back that support without
#linedirectives by allowing locations in Razor source genned documents to be found by FAR even if they're hidden. It also tweaks the LSP source mapping code to drop results that can't be mapped, which actually matches was the VS side already did anyway. Finally it exposes a hook for Razor to implement a document excerpt service, which is something I punted previously because the results with the#linedirectives were good enough, but now they're really not.Commit-at-a-time review is probably simpler, to make it clear which change is for which purpose.