Skip to content

[vs17.14] Include ConfigurationManager in Microsoft.Build.vsix#14496

Open
AlesProkop wants to merge 1 commit into
dotnet:vs17.14from
AlesProkop:alesprokop/fix-vs1714-configurationmanager-vsix
Open

[vs17.14] Include ConfigurationManager in Microsoft.Build.vsix#14496
AlesProkop wants to merge 1 commit into
dotnet:vs17.14from
AlesProkop:alesprokop/fix-vs1714-configurationmanager-vsix

Conversation

@AlesProkop

@AlesProkop AlesProkop commented Jul 23, 2026

Copy link
Copy Markdown
Member

Fixes #14404

Context

The MSBuild configuration redirects System.Configuration.ConfigurationManager to version 10.0.0.8, but the explicit Microsoft.Build.vsix payload omitted the assembly.

Changes Made

  • Include System.Configuration.ConfigurationManager.dll in MSBuild\Current\Bin.
  • Increment the servicing version to 17.14.53.

Testing

  • ./build.cmd -v quiet /p:RunAnalyzers=false
  • Built src/Package/MSBuild.VSSetup/MSBuild.VSSetup.csproj with full-framework MSBuild.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 91fec5dd-9331-4376-8ba1-b9bb5d4fc34b
Copilot AI review requested due to automatic review settings July 23, 2026 06:37
@AlesProkop
AlesProkop requested a review from a team as a code owner July 23, 2026 06:37
@AlesProkop
AlesProkop temporarily deployed to copilot-pat-pool July 23, 2026 06:37 — with GitHub Actions Inactive
@AlesProkop
AlesProkop temporarily deployed to copilot-pat-pool July 23, 2026 06:37 — with GitHub Actions Inactive
@AlesProkop
AlesProkop temporarily deployed to copilot-pat-pool July 23, 2026 06:38 — with GitHub Actions Inactive

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a Visual Studio servicing regression where MSBuild’s Full Framework binding redirect for System.Configuration.ConfigurationManager points to MSBuild\Current\Bin\System.Configuration.ConfigurationManager.dll, but the Microsoft.Build.vsix payload did not include that assembly—causing in-proc tasks with ConfigurationManager dependencies to fail to load under the redirected policy.

Changes:

  • Add System.Configuration.ConfigurationManager.dll to the Microsoft.Build.vsix payload under MSBuild\Current\Bin.
  • Bump the servicing version from 17.14.52 to 17.14.53.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Package/MSBuild.VSSetup/files.swr Adds System.Configuration.ConfigurationManager.dll to the VSIX file manifest for MSBuild\Current\Bin.
eng/Versions.props Increments VersionPrefix to 17.14.53 for the servicing build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AlesProkop
AlesProkop temporarily deployed to copilot-pat-pool July 23, 2026 06:42 — with GitHub Actions Inactive
@AlesProkop
AlesProkop temporarily deployed to copilot-pat-pool July 23, 2026 06:45 — with GitHub Actions Inactive

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: [vs17.14] Include ConfigurationManager in Microsoft.Build.vsix

Clean servicing PR. No issues found.

  • Version bump (17.14.52 to 17.14.53): Routine servicing increment.
  • New System.Configuration.ConfigurationManager.dll entry: Correctly added to the VSIX.
  • No NGEN attributes: Consistent with non-hot-path assemblies like Microsoft.Bcl.HashCode.dll, System.Threading.Channels.dll, System.ValueTuple.dll.
  • No behavioral changes, so no ChangeWave, tests, or breaking-change concerns.

LGTM - no blocking or major issues.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by Expert Code Review (on open) for #14496 · 45.8 AIC · ⌖ 4.99 AIC · ⊞ 5K

@AlesProkop
AlesProkop requested a deployment to copilot-pat-pool July 23, 2026 06:45 — with GitHub Actions Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants