[vs17.14] Include ConfigurationManager in Microsoft.Build.vsix#14496
[vs17.14] Include ConfigurationManager in Microsoft.Build.vsix#14496AlesProkop wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 91fec5dd-9331-4376-8ba1-b9bb5d4fc34b
There was a problem hiding this comment.
Pull request overview
This PR fixes a Visual Studio servicing regression where MSBuild’s Full Framework binding redirect for System.Configuration.ConfigurationManager points to MSBuild\Current\Bin\System.Configuration.ConfigurationManager.dll, but the Microsoft.Build.vsix payload did not include that assembly—causing in-proc tasks with ConfigurationManager dependencies to fail to load under the redirected policy.
Changes:
- Add
System.Configuration.ConfigurationManager.dllto theMicrosoft.Build.vsixpayload underMSBuild\Current\Bin. - Bump the servicing version from
17.14.52to17.14.53.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Package/MSBuild.VSSetup/files.swr | Adds System.Configuration.ConfigurationManager.dll to the VSIX file manifest for MSBuild\Current\Bin. |
| eng/Versions.props | Increments VersionPrefix to 17.14.53 for the servicing build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review: [vs17.14] Include ConfigurationManager in Microsoft.Build.vsix
Clean servicing PR. No issues found.
- Version bump (17.14.52 to 17.14.53): Routine servicing increment.
- New System.Configuration.ConfigurationManager.dll entry: Correctly added to the VSIX.
- No NGEN attributes: Consistent with non-hot-path assemblies like Microsoft.Bcl.HashCode.dll, System.Threading.Channels.dll, System.ValueTuple.dll.
- No behavioral changes, so no ChangeWave, tests, or breaking-change concerns.
LGTM - no blocking or major issues.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
awmgmcpg
To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
Generated by Expert Code Review (on open) for #14496 · 45.8 AIC · ⌖ 4.99 AIC · ⊞ 5K
Fixes #14404
Context
The MSBuild configuration redirects
System.Configuration.ConfigurationManagerto version 10.0.0.8, but the explicitMicrosoft.Build.vsixpayload omitted the assembly.Changes Made
System.Configuration.ConfigurationManager.dllinMSBuild\Current\Bin.Testing
./build.cmd -v quiet /p:RunAnalyzers=falsesrc/Package/MSBuild.VSSetup/MSBuild.VSSetup.csprojwith full-framework MSBuild.