Add cold-start benchmark for MSBuild server#14452
Draft
OvesN wants to merge 1 commit into
Draft
Conversation
Add localization coverage to keep future startup reordering from formatting deferred logging warnings before console UI culture is applied. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
baronfel
reviewed
Jul 20, 2026
Comment on lines
+65
to
+84
| ProcessStartInfo startInfo = new() | ||
| { | ||
| FileName = _msbuildPath, | ||
| Arguments = $"\"{_projectPath}\" -nologo -verbosity:quiet -mt -nodeReuse:false -p:BenchmarkProcessIdFile=\"{_processIdPath}\"", | ||
| UseShellExecute = false, | ||
| RedirectStandardOutput = true, | ||
| RedirectStandardError = true, | ||
| CreateNoWindow = true, | ||
| }; | ||
| startInfo.Environment["MSBUILDUSESERVER"] = "1"; | ||
| startInfo.Environment["MSBUILDNODEHANDSHAKESALT"] = Guid.NewGuid().ToString("N"); | ||
| startInfo.Environment["MSBUILDENABLEALLPROPERTYFUNCTIONS"] = "1"; | ||
|
|
||
| using Process process = Process.Start(startInfo) | ||
| ?? throw new InvalidOperationException("Failed to start MSBuild."); | ||
| Task<string> outputTask = process.StandardOutput.ReadToEndAsync(); | ||
| Task<string> errorTask = process.StandardError.ReadToEndAsync(); | ||
| process.WaitForExit(); | ||
| string output = outputTask.GetAwaiter().GetResult(); | ||
| string error = errorTask.GetAwaiter().GetResult(); |
Member
There was a problem hiding this comment.
We're moving to target .NET 11 in Viktor's branch - suggest having the benchmarks target that and using the new One-shot process APIs to make sure you're not artificially stalling the stdout/stderr-draining worker threads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add localization coverage to keep future startup reordering from formatting deferred logging warnings before console UI culture is applied.
Fixes #
Context
Changes Made
Testing
Notes