Exit DrainPacketQueue thread when build completes. #12561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
Currently, the dedicated thread that handles processing the packet queue doesn't exit properly when build finishes. The threads are idle, but repeated builds create a new thread each time and they accumulate during the session:
The check for
IsExitPacket()
is slightly misleading since it checks for more than just the completion of the buildBy explicitly checking for the
NodeBuildComplete
packet, we can exit the processing loop and let the thread get cleaned up. Additionally, I named the dedicated thread to help identify issues like this in the future.Changes Made
Testing
Notes