-
Notifications
You must be signed in to change notification settings - Fork 830
Fix typos in diagnostics #18935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix typos in diagnostics #18935
Conversation
❗ Release notes requiredCaution No release notes found for the changed paths (see table below). Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format. The following format is recommended for this repository:
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request. You can open this PR in browser to add release notes: open in github.dev
|
src/Compiler/FSStrings.resx
Outdated
<value>This construct causes code to be less generic than indicated by the type annotations. The unit-of-measure variable '{0}' has been constrained to be measure '{1}'.</value> | ||
</data> | ||
<data name="NonRigidTypar3" xml:space="preserve"> | ||
<value>This construct causes code to be less generic than indicated by the type annotations. The type variable '{0} has been constrained to be type '{1}'.</value> | ||
<value>This construct causes code to be less generic than indicated by the type annotations. The type variable '{0}' has been constrained to be type '{1}'.</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been intentional, to align with naming for typars, like
'a , 'b when ..
This came across at #18810 . The thread has a discussion on the topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue shows that this is a source of confusion, so it would definitely benefit from finishing the discussion and changing how the error is rendered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clarification, yeah, that got me confused too. 😅 Though I would probably understand it in the final diagnostics.
If not a typo, maybe it is a bit inconsistent there and should be ''{0}'
to align with other places where pieces of syntax are put into apostrophes. In either case, I will remove this from the pull request.
Description
Fixes a typo in compiler diagnostics:
of
toor
in FS3519.Checklist
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated: