-
Notifications
You must be signed in to change notification settings - Fork 383
Use SlnGen to generate solution from Traversal project #5600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
From a technical perspective, I like the traversal better. That being said:
|
steveisok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if there is a need for the prior .sln format, we can easily bring it back. I suspect it's just easier to manage .slnx files, but AI is also good at structuring the .sln file for you.
766a56f to
9fca247
Compare
hoyosjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :) Much easier to reason about and still have a reasonable loop
Updates repository to use
Microsoft.Build.Traversal.projfiles to drive which projects are built. Previously the arcade build infrastructure would build the solution files found in the root directly. This approach gives us more fine-grained control over projects to build, as well as allow us to automatically generate a solution file usingslngen.I have checked in the generated
build.slnwhich can be loaded withVSorVSCode. This version includes thevcxprojfiles which improve the native debug experience in VS. There is an option to generatebuild.slnwithout these files as they can cause warnings on non-Windows platforms (same behavior as today).For convienence I have added two new scripts:
eng/generate-sln.ps1eng/generate-sln.shboth of these automatically invoke the proper commands to regenerate the
build.slnfile.I updated the instruction docs to reference
build.slnand explain how to regenerate it.Edit:
slnx -> slnas the conversion process causes some problems with the vcxproj Ids. Given that these are now auto-generated, using theslnformat seems acceptable as it has broader support.