Skip to content

API Diff .NET 9.0 -> 10.0 #10147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

API Diff .NET 9.0 -> 10.0 #10147

wants to merge 3 commits into from

Conversation

@PranavSenthilnathan
Copy link
Member

@PranavSenthilnathan PranavSenthilnathan commented Nov 4, 2025 •
edited by adamsitnik
Loading

Library area owners:

  • System.Collections.Immutable: @dotnet/area-system-collections
  • System.Collections: @dotnet/area-system-collections
  • System.Collections.Specialized: @dotnet/area-system-collections
  • System.ComponentModel.Annotations: @dotnet/area-system-componentmodel
  • System.Console: @dotnet/area-system-console
  • System.Data.Common: @roji @cincuranet
  • System.Diagnostics.DiagnosticSource: @dotnet/area-system-diagnostics
  • System.Diagnostics.Process: @dotnet/area-system-diagnostics-process
  • System.Diagnostics.Tracing: @dotnet/area-system-diagnostics-tracing
  • System.Formats.Asn1: @dotnet/area-system-formats-asn1
  • System.IO.Compression: @dotnet/area-system-io-compression
  • System.IO.Compression.ZipFile: @dotnet/area-system-io-compression
  • System.Linq.AsyncEnumerable: @dotnet/area-system-linq
  • System.Linq: @dotnet/area-system-linq
  • System.Linq.Queryable: @dotnet/area-system-linq
  • System.Memory: @dotnet/area-system-memory
  • System.Net.Http: @dotnet/ncl
  • System.Net.Mail: @dotnet/ncl
  • System.Net.Primitives: @dotnet/ncl
  • System.Net.Quic: @dotnet/ncl
  • System.Net.Security: @dotnet/ncl
  • System.Net.ServerSentEvents: @dotnet/ncl
  • System.Net.WebSockets: @dotnet/ncl
  • System.Numerics.Vectors: @dotnet/area-system-numerics
  • System.Reflection.Emit: @dotnet/area-system-reflection-emit
  • System.Reflection.Metadata: @dotnet/area-system-reflection-metadata
  • System.Runtime.InteropServices: @AaronRobinsonMSFT @jkoritzinsky
  • System.Runtime.Intrinsics: @dotnet/area-system-runtime-intrinsics
  • System.Runtime.Loader: @dotnet/area-system-runtime
  • System.Runtime: @dotnet/area-system-runtime
  • System.Runtime.Serialization.Xml: @dotnet/area-system-runtime
  • System.Security.Claims: @dotnet/area-system-security
  • System.Security.Cryptography: @dotnet/area-system-security
  • System.Text.Json: @dotnet/area-system-text-json
  • System.Threading.AccessControl: @VSadov
  • System.Threading: @VSadov
  • System.Xml.ReaderWriter: @dotnet/area-system-xml
  • System.Xml.XmlSerializer: @dotnet/area-system-xml

@richlander
Copy link
Member

richlander commented Nov 4, 2025 •
edited
Loading

Thanks for publishing this before GA day!

I was hoping this diff would be at 10.0/api-diff. It's not really specific to 10.0.0 and that has poor discoverability.

@ericstj
Copy link
Member

ericstj commented Nov 4, 2025

I don't know if we actually need folks to individually review here, should we "trust the process"?

@richlander
Copy link
Member

richlander commented Nov 4, 2025

I agree. We should merge and allow for people to make edits afterwards if they find mistakes. The review always takes a long time and the feedback (if any) is always super targeted.

It would be great however if we could move the location of the diff, however, first.

eiriktsarpalis
eiriktsarpalis reviewed Nov 6, 2025
View reviewed changes
release-notes/10.0/api-diff/Microsoft.NETCore.App/10.0.0_System.Collections.md
}
- namespace System.Collections.ObjectModel
- {
- public class ReadOnlySet<T> : System.Collections.Generic.ICollection<T>, System.Collections.Generic.IEnumerable<T>, System.Collections.IEnumerable, System.Collections.Generic.IReadOnlyCollection<T>, System.Collections.Generic.IReadOnlySet<T>, System.Collections.Generic.ISet<T>, System.Collections.ICollection
Copy link
Member

@eiriktsarpalis eiriktsarpalis Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being removed?

Copy link
Member

@ViktorHofer ViktorHofer Nov 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just double checked this for sanity. The type got moved from System.Collections.dll to System.Runtime.dll in the reference assembly: https://github.com/dotnet/core/pull/10147/files#diff-2bf320cc1e60dff83561a22e9f25b68d2133f5c1d1de3327df8a515827ae58d1R97

Copy link
Member

@ViktorHofer ViktorHofer Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet/runtime#106037

@ufcpp ufcpp mentioned this pull request Nov 12, 2025
Open
@PranavSenthilnathan PranavSenthilnathan marked this pull request as ready for review November 14, 2025 23:05
adamsitnik
adamsitnik approved these changes Nov 18, 2025
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Console LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis left review comments

@ViktorHofer ViktorHofer ViktorHofer left review comments

@adamsitnik adamsitnik adamsitnik approved these changes

@ericstj ericstj ericstj approved these changes

@rbhanda rbhanda Awaiting requested review from rbhanda rbhanda is a code owner

@leecow leecow Awaiting requested review from leecow leecow is a code owner

@victorisr victorisr Awaiting requested review from victorisr victorisr is a code owner

Assignees

@PranavSenthilnathan PranavSenthilnathan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@PranavSenthilnathan @richlander @ericstj @eiriktsarpalis @adamsitnik @ViktorHofer