[typescript-resolvers] Add addInterfaceFieldResolverTypes option #10449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shared field inherit behaviour
🦋 Changeset detectedLatest commit: b40a8cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-codegen/visitor-plugin-common |
6.1.0-alpha-20251001144629-b40a8cbfdf8586bb3e4a3d39cbd6c6b0d4f1bb74 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-document-nodes |
5.0.2-alpha-20251001144629-b40a8cbfdf8586bb3e4a3d39cbd6c6b0d4f1bb74 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/gql-tag-operations |
5.0.2-alpha-20251001144629-b40a8cbfdf8586bb3e4a3d39cbd6c6b0d4f1bb74 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
5.0.2-alpha-20251001144629-b40a8cbfdf8586bb3e4a3d39cbd6c6b0d4f1bb74 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
5.1.0-alpha-20251001144629-b40a8cbfdf8586bb3e4a3d39cbd6c6b0d4f1bb74 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typed-document-node |
6.0.2-alpha-20251001144629-b40a8cbfdf8586bb3e4a3d39cbd6c6b0d4f1bb74 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript |
5.0.2-alpha-20251001144629-b40a8cbfdf8586bb3e4a3d39cbd6c6b0d4f1bb74 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
5.0.3-alpha-20251001144629-b40a8cbfdf8586bb3e4a3d39cbd6c6b0d4f1bb74 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/graphql-modules-preset |
5.0.3-alpha-20251001144629-b40a8cbfdf8586bb3e4a3d39cbd6c6b0d4f1bb74 |
npm ↗︎ unpkg ↗︎ |
💻 Website PreviewThe latest changes are available as preview in: https://pr-10449.graphql-code-generator.pages.dev |
eddeee888
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We removed
onlyResolveTypeForInterfacesoption here and made Interface not have resolvers for shared fields. This is because this is the default GraphQL resolver behaviour.However, some tools like
@graphql-tools/schema's makeExecutableSchema may change this default behaviour withinheritResolversFromInterfaces: trueoption so users only have to declare the shared field resolvers once in Interfaces, and implementing types can inherit said resolvers (if none available at the implementing types level).This PR adds
addInterfaceFieldResolverTypesas a replacement foronlyResolveTypeForInterfacesso users must consciously turn this option on when using with tools that customise the behaviours.Relevant questions: #10218 (comment), #10438 (comment)
Type of change
How Has This Been Tested?