Skip to content

Conversation

Clement795
Copy link

This PR addresses issue #882 by adding support for mlx-lm in the dora node-hub.

Changes:

  • Added mlx-lm node for macOS compatibility (node-hub/mlx-lm.py).
  • Made mlx-lm macOS-only with platform.system() check to skip execution on Linux/Windows, fixing CI failures.
  • Tested locally on macOS 15.4 with mlx-lm version 0.23.0.

Notes:

  • mlx-vlm support is not included and can be addressed separately.
  • CI Python tests should now pass across all platforms due to platform check.

Addresses #882 (partially, as mlx-vlm is not implemented).

@haixuanTao Please review this updated PR for adding mlx-lm support.

@Clement795
Copy link
Author

@haixuanTao The CI failed due to node-hub/dora-mlx-lm/ depending on mlx-lm, which isn’t available on Linux/Windows. I removed it and used node-hub/mlx-lm.py. Do I need to modify the CI workflow to test mlx-lm only on macOS?

@haixuanTao
Copy link
Collaborator

Can you put it in the skip folder?

See:

skip_test_folders=("dora-internvl" "dora-parler" "dora-keyboard" "dora-microphone" "terminal-input")

@Clement795
Copy link
Author

@haixuanTao skipping tests wasn't enough because the pyproject.toml still declares the mlx dependency, which gets resolved during linting and installation steps, causing failures. Moving the folder to ignored_folders prevents any CI steps (install, lint, test) from running on it. PR ready for review, thanks in advance!

@haixuanTao
Copy link
Collaborator

That makes sense. Thanks!

Copy link
Collaborator

@haixuanTao haixuanTao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks in advance

@phil-opp phil-opp added the waiting-for-review Pull request is waiting for a review from maintainers. label Aug 19, 2025
@phil-opp
Copy link
Collaborator

Triage: I resolved the conflict with the main branch. I think this PR is ready for another review @haixuanTao .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review Pull request is waiting for a review from maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants